From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752925AbZKDAOF (ORCPT ); Tue, 3 Nov 2009 19:14:05 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752471AbZKDAOE (ORCPT ); Tue, 3 Nov 2009 19:14:04 -0500 Received: from mail2.asahi-net.or.jp ([202.224.39.198]:22250 "EHLO mail2.asahi-net.or.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752439AbZKDAOE (ORCPT ); Tue, 3 Nov 2009 19:14:04 -0500 Date: Wed, 04 Nov 2009 09:14:07 +0900 Message-ID: From: Hirokazu Takata To: Roel Kluin Cc: Hirokazu Takata , linux-m32r@ml.linux-m32r.org, Andrew Morton , LKML Subject: Re: [PATCH] m32r: Should index be positive? In-Reply-To: <4AED9C22.3040301@gmail.com> References: <4AED9C22.3040301@gmail.com> User-Agent: Wanderlust/2.14.0 (Africa) Emacs/22.2 Mule/5.0 (SAKAKI) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Sun, 01 Nov 2009 15:33:06 +0100, Roel Kluin wrote: > > Index `ipi_num' is signed, test whether it is negative to > make sure we don't get a negative array element. > > Signed-off-by: Roel Kluin > --- > arch/m32r/kernel/smp.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > Found by code analysis, is it required? > > diff --git a/arch/m32r/kernel/smp.c b/arch/m32r/kernel/smp.c > index 8a88f1f..31cef20 100644 > --- a/arch/m32r/kernel/smp.c > +++ b/arch/m32r/kernel/smp.c > @@ -806,7 +806,7 @@ unsigned long send_IPI_mask_phys(cpumask_t physid_mask, int ipi_num, > > if (mask & ~physids_coerce(phys_cpu_present_map)) > BUG(); > - if (ipi_num >= NR_IPIS) > + if (ipi_num >= NR_IPIS || ipi_num < 0) > BUG(); > > mask <<= IPI_SHIFT; > Acked-by: Hirokazu Takata It looks OK for me. I've merged this patch into my tree. Thank you. -- Takata