From: Hirokazu Takata <takata@linux-m32r.org>
To: Julia Lawall <julia@diku.dk>
Cc: takata@linux-m32r.org, linux-m32r@ml.linux-m32r.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 8/15] arch/m32r: Use DIV_ROUND_CLOSEST
Date: Wed, 04 Nov 2009 09:11:36 +0900 [thread overview]
Message-ID: <swf8weni1xj.wl%takata@linux-m32r.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0908021047060.15557@ask.diku.dk>
At Sun, 2 Aug 2009 10:47:27 +0200 (CEST),
Julia Lawall wrote:
>
> From: Julia Lawall <julia@diku.dk>
>
> The kernel.h macro DIV_ROUND_CLOSEST performs the computation (x + d/2)/d
> but is perhaps more readable.
>
> The semantic patch that makes this change is as follows:
> (http://www.emn.fr/x-info/coccinelle/)
>
> // <smpl>
> @haskernel@
> @@
>
> #include <linux/kernel.h>
>
> @depends on haskernel@
> expression x,__divisor;
> @@
>
> - (((x) + ((__divisor) / 2)) / (__divisor))
> + DIV_ROUND_CLOSEST(x,__divisor)
> // </smpl>
>
> Signed-off-by: Julia Lawall <julia@diku.dk>
>
> ---
> arch/m32r/kernel/time.c | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/m32r/kernel/time.c b/arch/m32r/kernel/time.c
> index cada3ba..49648ba 100644
> --- a/arch/m32r/kernel/time.c
> +++ b/arch/m32r/kernel/time.c
> @@ -66,7 +66,7 @@ static unsigned long do_gettimeoffset(void)
> count = 0;
>
> count = (latch - count) * TICK_SIZE;
> - elapsed_time = (count + latch / 2) / latch;
> + elapsed_time = DIV_ROUND_CLOSEST(count, latch);
> /* NOTE: LATCH is equal to the "interval" value (= reload count). */
>
> #else /* CONFIG_SMP */
> @@ -84,7 +84,7 @@ static unsigned long do_gettimeoffset(void)
> p_count = count;
>
> count = (latch - count) * TICK_SIZE;
> - elapsed_time = (count + latch / 2) / latch;
> + elapsed_time = DIV_ROUND_CLOSEST(count, latch);
> /* NOTE: LATCH is equal to the "interval" value (= reload count). */
> #endif /* CONFIG_SMP */
> #elif defined(CONFIG_CHIP_M32310)
> @@ -270,7 +270,7 @@ void __init time_init(void)
>
> bus_clock = boot_cpu_data.bus_clock;
> divide = boot_cpu_data.timer_divide;
> - latch = (bus_clock/divide + HZ / 2) / HZ;
> + latch = DIV_ROUND_CLOSEST(bus_clock/divide, HZ);
>
> printk("Timer start : latch = %ld\n", latch);
>
>
Acked-by: Hirokazu Takata <takata@linux-m32r.org>
I've merged this patch into my tree.
Thank you.
-- Takata
prev parent reply other threads:[~2009-11-04 0:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-02 8:47 Julia Lawall
2009-11-04 0:11 ` Hirokazu Takata [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=swf8weni1xj.wl%takata@linux-m32r.org \
--to=takata@linux-m32r.org \
--cc=julia@diku.dk \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m32r@ml.linux-m32r.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®