From: Hirokazu Takata <takata@linux-m32r.org>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: Hirokazu Takata <takata@linux-m32r.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 8/13] cpumask: use mm_cpumask() wrapper: m32r
Date: Wed, 23 Sep 2009 22:29:01 +0900 [thread overview]
Message-ID: <swfiqf9okma.wl%takata@linux-m32r.org> (raw)
In-Reply-To: <20090612133101.0FF8BDDD0C@ozlabs.org>
Hello,
I apologize for my too late reply.
I've checked the patch and fixed two typos.
Thank you.
Signed-off-by: Hirokazu Takata <takata@linux-m32r.org>
---
arch/m32r/include/asm/mmu_context.h | 2 +-
arch/m32r/kernel/smp.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/m32r/include/asm/mmu_context.h b/arch/m32r/include/asm/mmu_context.h
index a735cc5..a70a3df 100644
--- a/arch/m32r/include/asm/mmu_context.h
+++ b/arch/m32r/include/asm/mmu_context.h
@@ -135,7 +135,7 @@ static inline void switch_mm(struct mm_struct *prev,
}
#ifdef CONFIG_SMP
else
- if (!cpumask_test_and_set_cpu(cpu, mm_cpumask(next))
+ if (!cpumask_test_and_set_cpu(cpu, mm_cpumask(next)))
activate_context(next);
#endif /* CONFIG_SMP */
}
diff --git a/arch/m32r/kernel/smp.c b/arch/m32r/kernel/smp.c
index e6ec3cc..1b7598e 100644
--- a/arch/m32r/kernel/smp.c
+++ b/arch/m32r/kernel/smp.c
@@ -469,7 +469,7 @@ void smp_invalidate_interrupt(void)
if (flush_mm == current->active_mm)
activate_context(flush_mm);
else
- cpumask_clear(cpu_id, mm_cpumask(flush_mm));
+ cpumask_clear_cpu(cpu_id, mm_cpumask(flush_mm));
} else {
unsigned long va = flush_va;
--
1.6.4.4
At Fri, 12 Jun 2009 22:33:14 +0930,
Rusty Russell wrote:
>
>
> Makes code futureproof against the impending change to mm->cpu_vm_mask.
>
> It's also a chance to use the new cpumask_ ops which take a pointer
> (the older ones are deprecated, but there's no hurry for arch code).
>
> Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
> ---
> arch/m32r/include/asm/mmu_context.h | 4 ++--
> arch/m32r/kernel/smp.c | 8 ++++----
> 2 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/arch/m32r/kernel/smp.c b/arch/m32r/kernel/smp.c
> --- a/arch/m32r/kernel/smp.c
> +++ b/arch/m32r/kernel/smp.c
> @@ -264,7 +264,7 @@ void smp_flush_tlb_mm(struct mm_struct *
> preempt_disable();
> cpu_id = smp_processor_id();
> mmc = &mm->context[cpu_id];
> - cpu_mask = mm->cpu_vm_mask;
> + cpu_mask = *mm_cpumask(mm);
> cpu_clear(cpu_id, cpu_mask);
>
> if (*mmc != NO_CONTEXT) {
> @@ -273,7 +273,7 @@ void smp_flush_tlb_mm(struct mm_struct *
> if (mm == current->mm)
> activate_context(mm);
> else
> - cpu_clear(cpu_id, mm->cpu_vm_mask);
> + cpumask_clear_cpu(cpu_id, mm_cpumask(mm));
> local_irq_restore(flags);
> }
> if (!cpus_empty(cpu_mask))
> @@ -334,7 +334,7 @@ void smp_flush_tlb_page(struct vm_area_s
> preempt_disable();
> cpu_id = smp_processor_id();
> mmc = &mm->context[cpu_id];
> - cpu_mask = mm->cpu_vm_mask;
> + cpu_mask = *mm_cpumask(mm);
> cpu_clear(cpu_id, cpu_mask);
>
> #ifdef DEBUG_SMP
> @@ -469,7 +469,7 @@ void smp_invalidate_interrupt(void)
> if (flush_mm == current->active_mm)
> activate_context(flush_mm);
> else
> - cpu_clear(cpu_id, flush_mm->cpu_vm_mask);
> + cpumask_clear(cpu_id, mm_cpumask(flush_mm));
> } else {
> unsigned long va = flush_va;
>
> diff --git a/arch/m32r/include/asm/mmu_context.h b/arch/m32r/include/asm/mmu_context.h
> --- a/arch/m32r/include/asm/mmu_context.h
> +++ b/arch/m32r/include/asm/mmu_context.h
> @@ -127,7 +127,7 @@ static inline void switch_mm(struct mm_s
>
> if (prev != next) {
> #ifdef CONFIG_SMP
> - cpu_set(cpu, next->cpu_vm_mask);
> + cpumask_set_cpu(cpu, mm_cpumask(next));
> #endif /* CONFIG_SMP */
> /* Set MPTB = next->pgd */
> *(volatile unsigned long *)MPTB = (unsigned long)next->pgd;
> @@ -135,7 +135,7 @@ static inline void switch_mm(struct mm_s
> }
> #ifdef CONFIG_SMP
> else
> - if (!cpu_test_and_set(cpu, next->cpu_vm_mask))
> + if (!cpumask_test_and_set_cpu(cpu, mm_cpumask(next))
> activate_context(next);
> #endif /* CONFIG_SMP */
> }
>
next prev parent reply other threads:[~2009-09-23 13:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-12 13:03 Rusty Russell
2009-09-23 13:29 ` Hirokazu Takata [this message]
2009-09-24 0:05 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=swfiqf9okma.wl%takata@linux-m32r.org \
--to=takata@linux-m32r.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®