From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner+w=401wt.eu-S1759349AbYEINiH@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1759349AbYEINiH (ORCPT <rfc822;w@1wt.eu>);
	Fri, 9 May 2008 09:38:07 -0400
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751563AbYEINhz
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Fri, 9 May 2008 09:37:55 -0400
Received: from mail.renesas.com ([202.234.163.13]:50955 "EHLO
	mail02.idc.renesas.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org
	with ESMTP id S1751079AbYEINhz (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 9 May 2008 09:37:55 -0400
Date: Fri, 09 May 2008 22:37:51 +0900
From: Hirokazu Takata <takata@linux-m32r.org>
Subject: Re: [PATCH] m32r: use generic sys_pipe
In-reply-to: <20080509124402.GA14406@lst.de>
To: Christoph Hellwig <hch@lst.de>
Cc: Hirokazu Takata <takata@linux-m32r.org>, torvalds@osdl.org,
       linux-m32r@ml.linux-m32r.org, linux-kernel@vger.kernel.org
Message-id: <swfod7f38eo.wl%takata.hirokazu@renesas.com>
MIME-version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-type: text/plain; charset=US-ASCII
User-Agent: Wanderlust/2.14.0 (Africa) Emacs/21.4 Mule/5.0 (SAKAKI)
References: <20080509124402.GA14406@lst.de>
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi, Christoph,

Please sign off this patch.

Thanks,

From: Christoph Hellwig <hch@lst.de>
Subject: [PATCH] m32r: use generic sys_pipe
Date: Fri, 09 May 2008 14:44:02 +0200
> m32r can use the generic sys_pipe implementation.
> 
> The current sys_pipe implementation on m32r only differes from the
> generic one by passing a lot of additional unused registers to sys_pipe.
> 
> Reviewed and tested by Hirokazu Takata.

Signed-off-by: Hirokazu Takata <takata@linux-m32r.org>

> Index: linux-2.6/arch/m32r/kernel/sys_m32r.c
> ===================================================================
> --- linux-2.6.orig/arch/m32r/kernel/sys_m32r.c	2008-05-09 12:44:10.000000000 +0200
> +++ linux-2.6/arch/m32r/kernel/sys_m32r.c	2008-05-09 12:44:16.000000000 +0200
> @@ -76,29 +76,6 @@ asmlinkage int sys_tas(int __user *addr)
>  	return oldval;
>  }
>  
> -/*
> - * sys_pipe() is the normal C calling standard for creating
> - * a pipe. It's not the way Unix traditionally does this, though.
> - */
> -asmlinkage int
> -sys_pipe(unsigned long r0, unsigned long r1, unsigned long r2,
> -	unsigned long r3, unsigned long r4, unsigned long r5,
> -	unsigned long r6, struct pt_regs regs)
> -{
> -	int fd[2];
> -	int error;
> -
> -	error = do_pipe(fd);
> -	if (!error) {
> -		if (copy_to_user((void __user *)r0, fd, 2*sizeof(int))) {
> -			sys_close(fd[0]);
> -			sys_close(fd[1]);
> -			error = -EFAULT;
> -		}
> -	}
> -	return error;
> -}
> -
>  asmlinkage long sys_mmap2(unsigned long addr, unsigned long len,
>  	unsigned long prot, unsigned long flags,
>  	unsigned long fd, unsigned long pgoff)
>