From: Hirokazu Takata <takata@linux-m32r.org>
To: Al Viro <viro@ftp.linux.org.uk>
Cc: torvalds@linux-foundation.org, linux-kernel@vger.kernel.org,
takata@linux-m32r.org
Subject: Re: [PATCH] [m32r] __xchg() should be always_inline
Date: Wed, 16 May 2007 10:37:11 +0900 [thread overview]
Message-ID: <swfodkly2ew.wl%takata.hirokazu@renesas.com> (raw)
In-Reply-To: <E1Ho2pQ-0003Uu-BS@ZenIV.linux.org.uk>
Thank you.
Acked-by: Hirokazu Takata <takata@linux-m32r.org>
From: Al Viro <viro@ftp.linux.org.uk>
Subject: [PATCH] [m32r] __xchg() should be always_inline
Date: Tue, 15 May 2007 20:37:00 +0100
>
> it depends on elimination of unreachable branches in switch (by object
> size), so we must declare it always_inline
>
> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
> ---
> include/asm-m32r/system.h | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/include/asm-m32r/system.h b/include/asm-m32r/system.h
> index b291b2f..8ee73d3 100644
> --- a/include/asm-m32r/system.h
> +++ b/include/asm-m32r/system.h
> @@ -10,6 +10,7 @@
> * Copyright (C) 2004, 2006 Hirokazu Takata <takata at linux-m32r.org>
> */
>
> +#include <linux/compiler.h>
> #include <asm/assembler.h>
>
> #ifdef __KERNEL__
> @@ -154,7 +155,7 @@ extern void __xchg_called_with_bad_pointer(void);
> #define DCACHE_CLEAR(reg0, reg1, addr)
> #endif /* CONFIG_CHIP_M32700_TS1 */
>
> -static inline unsigned long
> +static __always_inline unsigned long
> __xchg(unsigned long x, volatile void * ptr, int size)
> {
> unsigned long flags;
> --
> 1.5.0-rc2.GIT
>
>
prev parent reply other threads:[~2007-05-16 1:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-15 19:37 Al Viro
2007-05-16 1:37 ` Hirokazu Takata [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=swfodkly2ew.wl%takata.hirokazu@renesas.com \
--to=takata@linux-m32r.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=viro@ftp.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®