From: bo cao <treebacker@foxmail.com>
To: Xu Yilun <yilun.xu@linux.intel.com>
Cc: linux-fpga@vger.kernel.org, linux-kernel@vger.kernel.org,
Tom Rix <trix@redhat.com>, Abdifatah Suruur <suruurism@gmail.com>
Subject: Re: [PATCH] fpga: dfl: afu: prevent read-only region mappings from becoming writable
Date: Mon, 9 Nov 2026 10:59:53 +0800 [thread overview]
Message-ID: <tencent_08CE0BB6708C964EEA0A1358355065F23506@qq.com> (raw)
In-Reply-To: <au8LKUyKQpGCy58F@yilunxu-OptiPlex-7050>
Please consider this patch withdrawn: Abdifatah Suruur's patch
already covers it, and his v2 was posted to linux-fpga on Oct 23,
six days before my posting.
To be clear about where this came from: it is not taken from
Suruur's patch. I run an AI-agent-assisted audit of mmap/mprotect
permission handling, and it independently flagged afu_mmap() as
leaving VM_MAYWRITE set on regions without DFL_PORT_REGION_WRITE,
and drafted the fix. Two fixes of the same one-line issue, citing
the same precedent commits of this pattern, necessarily read alike
-- but I understand that from your side the result is
indistinguishable from a copy, and the concern is legitimate.
The pre-send duplicate check in my tooling queries lore.kernel.org,
which is behind an anti-bot challenge, so it returned nothing and
the overlap with Suruur's live thread slipped through. I should
not have relied on it alone. I'm sorry for the noise.
Going forward I will manually search the list archive (marc.info,
openwall mirrors) before sending anything, and I will write the
changelog and comments by hand, so that what reaches you reflects
my own understanding of the change. Where my audit finds an issue
that an existing thread already covers, I will comment on that
thread instead of sending a duplicate.
Apologies,
Bo Cao
prev parent reply other threads:[~2026-11-09 2:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-29 3:53 bo cao
2026-11-07 11:27 ` Xu Yilun
2026-11-09 2:59 ` bo cao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tencent_08CE0BB6708C964EEA0A1358355065F23506@qq.com \
--to=treebacker@foxmail.com \
--cc=linux-fpga@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=suruurism@gmail.com \
--cc=trix@redhat.com \
--cc=yilun.xu@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®