From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751850AbdIUE2n (ORCPT <rfc822;w@1wt.eu>);
        Thu, 21 Sep 2017 00:28:43 -0400
Received: from smtpbgbr2.qq.com ([54.207.22.56]:44490 "EHLO smtpbgbr2.qq.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751828AbdIUE2l (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 21 Sep 2017 00:28:41 -0400
X-QQ-GoodBg: 0
X-QQ-SSF: 00100000000000F0
X-QQ-FEAT: GIZYjJ20DPcQd90Fw4vts94GwZ6CQASFCTdm2fj0o9n34ACMuBedl3z4Pr/TO
        kQV5/QlGWwYk7SRk48tIC19UPZkd3x8fRnjz7rZXG3ytX0KSMqkUNqFzH6BrFhIFRYM/yJy
        sguOwO+zhZZf36QuPe2ZP8FY/zJJd26KSGDmWMYclCGkYD6i5eR5gqjnXQHKftD6oHNfbZs
        j1qWaKlnHlkuGfwa7qLb8zgWY58qqezXE9g6qRMSjaGGy3y+maG5IrV9HcyRIBetllbQGrV
        uF3d+gy6ubJ3jlI6L4auU9ybM=
X-QQ-BUSINESS-ORIGIN: 2
X-Originating-IP: 222.92.124.153
X-QQ-STYLE: 
X-QQ-mid: bizmailfree34t1505968105t5343
From: "=?utf-8?B?6ZmI5Y2O5omN?=" <chenhc@lemote.com>
To: "=?utf-8?B?Q2hyaXN0b3BoIEhlbGx3aWc=?=" <hch@lst.de>
Cc: "=?utf-8?B?Q2hyaXN0b3BoIEhlbGx3aWc=?=" <hch@lst.de>,
        "=?utf-8?B?TWFyZWsgU3p5cHJvd3NraQ==?=" <m.szyprowski@samsung.com>,
        "=?utf-8?B?Um9iaW4gTXVycGh5?=" <robin.murphy@arm.com>,
        "=?utf-8?B?QW5kcmV3IE1vcnRvbg==?=" <akpm@linux-foundation.org>,
        "=?utf-8?B?RnV4aW4gWmhhbmc=?=" <zhangfx@lemote.com>,
        "=?utf-8?B?bGludXgta2VybmVs?=" <linux-kernel@vger.kernel.org>,
        "=?utf-8?B?SmFtZXMgRSAuIEogLiBCb3R0b21sZXk=?=" 
        <jejb@linux.vnet.ibm.com>,
        "=?utf-8?B?TWFydGluIEsgLiBQZXRlcnNlbg==?=" 
        <martin.petersen@oracle.com>,
        "=?utf-8?B?bGludXgtc2NzaQ==?=" <linux-scsi@vger.kernel.org>,
        "=?utf-8?B?c3RhYmxl?=" <stable@vger.kernel.org>
Subject: Re: [PATCH V6 2/3] dma-mapping: Rework dma_get_cache_alignment()function
Mime-Version: 1.0
Content-Type: text/plain;
        charset="utf-8"
Date: Thu, 21 Sep 2017 12:28:25 +0800
X-Priority: 3
Message-ID: <tencent_0C366F4D229840FF7D683E10@qq.com>
X-QQ-MIME: TCMime 1.0 by Tencent
X-Mailer: QQMail 2.x
X-QQ-Mailer: QQMail 2.x
References: <1505811161-25246-1-git-send-email-chenhc@lemote.com>
        <1505811161-25246-2-git-send-email-chenhc@lemote.com>
        <20170919150252.GA23540@lst.de>
In-Reply-To: <20170919150252.GA23540@lst.de>
X-QQ-ReplyHash: 659848657
X-QQ-SENDSIZE: 520
Feedback-ID: bizmailfree:lemote.com:qybgforeign:qybgforeign2
X-QQ-Bgrelay: 1
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from base64 to 8bit by nfs id v8L4Smpj028652

Hi, Christoph,

I have changed dma_get_cache_alignment's return value, and I don't know whether those drivers want to return ARCH_DMA_MINALIGN unconditionally. So I pass a NULL for those drivers, in order to keep their old behavior.
 
Huacai
 
------------------ Original ------------------
From:  "Christoph Hellwig"<hch@lst.de>;
Date:  Tue, Sep 19, 2017 11:02 PM
To:  "Huacai Chen"<chenhc@lemote.com>; 
Cc:  "Christoph Hellwig"<hch@lst.de>; "Marek Szyprowski"<m.szyprowski@samsung.com>; "Robin Murphy"<robin.murphy@arm.com>; "Andrew Morton"<akpm@linux-foundation.org>; "Fuxin Zhang"<zhangfx@lemote.com>; "linux-kernel"<linux-kernel@vger.kernel.org>; "James E . J . Bottomley"<jejb@linux.vnet.ibm.com>; "Martin K . Petersen"<martin.petersen@oracle.com>; "linux-scsi"<linux-scsi@vger.kernel.org>; "stable"<stable@vger.kernel.org>; 
Subject:  Re: [PATCH V6 2/3] dma-mapping: Rework dma_get_cache_alignment()function

 
>  	mdev->limits.reserved_mtts = ALIGN(mdev->limits.reserved_mtts * mdev->limits.mtt_seg_size,
> -					   dma_get_cache_alignment()) / mdev->limits.mtt_seg_size;
> +					   dma_get_cache_alignment(NULL)) / mdev->limits.mtt_seg_size;
>  
>  	mdev->mr_table.mtt_table = mthca_alloc_icm_table(mdev, init_hca->mtt_base,

Please pass the actually relevant struct device for each call.