From: Yaxiong Tian <iambestgod@qq.com>
To: kbusch@kernel.org, axboe@kernel.dk, hch@lst.de, sagi@grimberg.me
Cc: linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org,
Yaxiong Tian <tianyaxiong@kylinos.cn>
Subject: [PATCH 1/3] nvme: Add warning for PST table memory allocation failure in nvme_configure_apst
Date: Wed, 26 Mar 2025 18:15:02 +0800 [thread overview]
Message-ID: <tencent_0E548E922D6CA7EC6F5789C998AF10CE0806@qq.com> (raw)
In-Reply-To: <tencent_FD614E97ED4F67FE2F74C9C158AB50E7C806@qq.com>
From: Yaxiong Tian <tianyaxiong@kylinos.cn>
Currently the function fails silently on PST table memory allocation failure.
Add warning messages to improve error visibility.
Signed-off-by: Yaxiong Tian <tianyaxiong@kylinos.cn>
---
drivers/nvme/host/core.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
index c2d89fac86c5..fb0404fee551 100644
--- a/drivers/nvme/host/core.c
+++ b/drivers/nvme/host/core.c
@@ -2678,8 +2678,10 @@ static int nvme_configure_apst(struct nvme_ctrl *ctrl)
}
table = kzalloc(sizeof(*table), GFP_KERNEL);
- if (!table)
+ if (!table) {
+ dev_warn(ctrl->device, "Failed to allocate pst table; not using APST\n");
return 0;
+ }
if (!ctrl->apst_enabled || ctrl->ps_max_latency_us == 0) {
/* Turn off APST. */
--
2.25.1
next prev parent reply other threads:[~2025-03-26 10:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-26 9:57 [PATCH 0/3] nvme: Add sysfs interface for APST configuration management Yaxiong Tian
2025-03-26 10:15 ` Yaxiong Tian [this message]
2025-03-26 10:16 ` [PATCH 2/3] nvme: add sysfs interface for APST table updates Yaxiong Tian
2025-03-26 10:16 ` [PATCH 3/3] nvme: add per-controller sysfs interface for APST configuration Yaxiong Tian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tencent_0E548E922D6CA7EC6F5789C998AF10CE0806@qq.com \
--to=iambestgod@qq.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
--cc=tianyaxiong@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®