From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out203-205-221-221.mail.qq.com (out203-205-221-221.mail.qq.com [203.205.221.221]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EBEE4370D5A for ; Tue, 21 Jul 2026 01:56:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=203.205.221.221 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784598989; cv=none; b=ARKxj29PE/TWnbM5PnqV0lYADmMNV1AUyO8Ax7bSJJMm7julLwQaO2Hi5VecO7vLRU/vtTOmM5UTspLmmZuu0Hu+gjHG7YSEEzyVSVZwYszRqiU5FEA6TNjae7a5yWpw6N8Ni/Aj+o2Z7sbXd1Av8Figfh7fhLqvfHsuH2Is/7A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784598989; c=relaxed/simple; bh=Xjg3PltNc1sYo38Zt2iNop90gKX5rxaYlYtNB7NQOZw=; h=Message-ID:From:To:Cc:Subject:Date:In-Reply-To:References: MIME-Version; b=OQv7Z8+i6nEgH/3qyt18xhMincfGYr453sOwKBy/nKdEWsmwmnDtDigJ8dt7Rx6iwldoJx8XL2Dh+XI1qkMwtQRug++UJUAzqZKk4UMYwvm2KKyHUIpppTLrNn4HXvOU4pWA2jWFugqCFmq6YLXnuQGfVyEuu4eNOCDFvURcNCw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=qq.com; spf=pass smtp.mailfrom=qq.com; dkim=pass (1024-bit key) header.d=qq.com header.i=@qq.com header.b=ewHIhLpY; arc=none smtp.client-ip=203.205.221.221 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=qq.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=qq.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=qq.com header.i=@qq.com header.b="ewHIhLpY" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qq.com; s=s201512; t=1784598978; bh=Xjg3PltNc1sYo38Zt2iNop90gKX5rxaYlYtNB7NQOZw=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=ewHIhLpYv4hIhy0WZ7vHLbY1zWmc0uZ4iYdlNrePiGvG87NBI8TuGOlLjC0x1teva tS4pWkd3xlcERpO5rV15eA0QMg1TwPMCPBnzJQRDUUqUbD5G681rmli0K81EAgANjw ib3fyqeVZqYiQHaMoS4JzIDTYSpdX2CJX8iQoYD4= Received: from ikun ([36.152.24.184]) by newxmesmtplogicsvrszb51-1.qq.com (NewEsmtp) with SMTP id E0F11C76; Tue, 21 Jul 2026 09:56:15 +0800 X-QQ-mid: xmsmtpt1784598975tme3lhrsm Message-ID: X-QQ-XMAILINFO: NMiAo2azIaDADUCoZuXWUMbRJo6tpQ6oNGQRHxrbqz20rsNCGJStcjUqC0Qhvk Rrbk7lnZs+l4x1373gVr8d6ISJkUulurkKgvqJlQR9NtkG46XaGtUyzlXHwF+rX+EhJRznufkrCy CQg9lkvKkG8rf0kapjiwoeyrpZA7IYUBkuGgL6u38sqiuO2MgylhoETEPbADAtjpgGa25bzCN299 Oie8cN2+inD+wmoJtTwQUuagbFrlL/fubouKxeXgch7zYVp3wd69jl1tHhouvQKvCJJsOfy7uOGG eo6bI9nEvo8oCMntfumE7tpdVuE4ieXqtUE3WEx/T6Jx/AG5oCYaYfrrk4SzO6s82NQUhTVaPqdk TPR4MhVNJHdr+2Ndiv089TkHt0KB95KXm2b//FT6YGKdR+4oIWYXhZwo3KqdbLZuJaPu+SZaZQGX wzXj1QhezyD70MGZSUky7bzQxRSsBf5j2MEbSge7aZOSV7f4gM76yu7iq7gfWvxIZlWMhqqfs/2Q dv9x+TbwUi64nGHDVOUQfKQ1sWQXDcKJHw0jcAMnXWuyOpezHXbiwqiksBfSVdX50itfwNs7POpz 3vcHDLCGBux/SFxiOUcp7Q3mxjtX5g3EeDPcZpWTvBfPDDBEhXNsj3/GojbJmKEmR20jmraORnuB HG6vEo17vdTGdwghbBHnrhegAmvyAVfM0//KLfVl3CJ+lAg5h9Ybfa23VT8gwsnfsQ58kk/dbL// g3vOJ2nqpUtmdwxSF0RSKKVufAyGfnC/wEyD9EVkVxWMIX3fU01Ue8PesptgQTaQ5k7f0ndMoDVC W40pe9gFmJJrLuV3RPlwZhdpH9/P3IbRAXZvhpZHIRLzWGbTG5FIEyEfd4JnYqPjpdKW/BpeksZJ MvyznDpE1XgXW3f9ne4klhFwmIdInWU8YaN0Sjk/FNXps0LT6u8ih9f3Ma1tbk/QmPKpeYgW7jDT mJ9cuMDkqpmxccnsIXoY3cnmQP7Jfcs3Ua4Dt4yMRen1sh8i0gJ8P2bnW1FUctJurYwwTzPayyaf KTbSlBFn8N1KTs3lkvSFexYLap3MA= X-QQ-XMRINFO: NS+P29fieYNwqS3WCnRCOn9D1NpZuCnCRA== From: Guanghui Yang <3497809730@qq.com> To: chao@kernel.org Cc: jaegeuk@kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, Guanghui Yang <3497809730@qq.com> Subject: Re: [PATCH] f2fs: fix ifolio leak in f2fs_move_inline_dirents Date: Tue, 21 Jul 2026 09:56:01 +0800 X-OQ-MSGID: <20260721015601.624-1-3497809730@qq.com> X-Mailer: git-send-email 2.52.0.windows.1 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit You are right. I misread the condition. When err is non-zero, f2fs_put_dnode() is called regardless of need_put, so dn.inode_folio is released on the f2fs_reserve_block() error path. The caller only releases ifolio on success because the error cleanup has already been handled here. Please ignore this patch. Sorry for the confusion. Thanks, Guanghui