From: jackysliu <1972843537@qq.com>
To: gregkh@linuxfoundation.org
Cc: 1972843537@qq.com, linux-kernel@vger.kernel.org,
linux-usb@vger.kernel.org, viro@zeniv.linux.org.uk
Subject: Re: [PATCH v2] usb: gadget: functioni: Fix a oob problem in rndis
Date: Fri, 11 Jul 2025 11:46:35 +0800 [thread overview]
Message-ID: <tencent_19AE390D05232D1C97E336C05F35A9F1BD05@qq.com> (raw)
In-Reply-To: <2025071010-outlet-stencil-663d@gregkh>
On Thu, 10 Jul 2025 14:19:47 +0200, greg k-h wrote
>In digging in this further, I don't see how this actually changes
>anything. BufLength is used for nothing that I can determine, except in
>some debugging code that is always compiled out (i.e. you can NOT enable
>it unless you modify the kernel source.)
>
>So what exactly is this check checking?
>
>I can see that we really should be checking if the buffer is too small,
>but that's not what you are doing here at all.
>
>And all this buffer is used for is to read a 32bit value out of, so
>verifying that the buffer really is big enough to hold that value SHOULD
>be what we do here, not check to see if the buffer is too big.
>
>Also, you can't trust that BufLength is even correct as it comes from
>the other side, right? Because of that, we should just be ignoring it
>entirely and verifying that the message size really is as big as the
>structure is supposed to be. But that means passing down the message
>size to the lower layers here, which gets into the issues that I have
>raised before many years ago about this protocol, and this
>implementation of this protocol. I.e, it is COMPLETELY INSECURE and
>should ONLY be used on systems where you trust both sides of the wire.
>
>Again, how was this change tested? And what exactly does it fix? I'm
>missing how this change is going to actually catch anything, can you
>spell it out in detail for me?
BufOffset + BufLength can exceed buffer size even if each is < RNDIS_MAX_TOTAL_SIZE
oob is triggered by a function call to gen_ndis_set_resp.
I supposed to add an additional boundry check to avoid this issue.But That
doesn't seem to be enough to fix the bug.I'll try to figure it out.
Thanks
Siyang Liu
next prev parent reply other threads:[~2025-07-11 3:47 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-10 8:14 [PATCH] " jackysliu
2025-07-10 8:21 ` Greg KH
2025-07-10 8:49 ` [PATCH v2] " jackysliu
2025-07-10 9:16 ` Greg KH
2025-07-10 9:33 ` jackysliu
2025-07-10 9:34 ` Greg KH
2025-07-10 12:19 ` Greg KH
2025-07-11 3:46 ` jackysliu [this message]
2025-07-11 5:54 ` Greg KH
2025-07-11 6:40 ` jackysliu
2025-07-11 6:51 ` Greg KH
2025-07-15 8:20 ` jackysliu
2025-07-15 8:32 ` Greg KH
2025-07-15 8:47 ` jackysliu
-- strict thread matches above, loose matches on Subject: below --
2025-06-19 4:03 [PATCH v2] scsi: fix out of bounds error in /drivers/scsi jackysliu
2025-07-15 7:56 ` [PATCH v2] usb: gadget: functioni: Fix a oob problem in rndis jackysliu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tencent_19AE390D05232D1C97E336C05F35A9F1BD05@qq.com \
--to=1972843537@qq.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®