mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Haozhen Li <dezige131@foxmail.com>
To: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Cc: Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	Abel Vesa <abelvesa@kernel.org>,
	Dawid Wrobel <me@dawidwrobel.com>,
	linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
	Amirreza Zarrabi <amirreza.zarrabi@oss.qualcomm.com>,
	Kuldeep Singh <kuldeep.singh@oss.qualcomm.com>,
	Harshal Dev <harshal.dev@oss.qualcomm.com>,
	Sumit Garg <sumit.garg@oss.qualcomm.com>,
	Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@oss.qualcomm.com>,
	Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>,
	Haozhen Li <dezige131@foxmail.com>
Subject: Re: [RFC PATCH 1/2] firmware: qcom: scm: Add QSEECOM app loading and shutdown
Date: Mon,  2 Nov 2026 16:27:28 +0000	[thread overview]
Message-ID: <tencent_1A709D2F1A0F149D99E48871997B9FB32607@qq.com> (raw)
In-Reply-To: <60afa31c-0c68-4e77-81b7-ef78f987f429@oss.qualcomm.com>

Hi Konrad,

Thanks for pointing these out.

You were completely right about the 4 GiB claim. I probed it on
sc8280xp by OR-ing bit 32 into an otherwise valid image address handed
to APP_START: a firmware reading only the low 32 bits would have
loaded from the untouched address and succeeded, but the call came
back with an explicit error (result 0xffffffffffffffd1, mapped by the
kernel to -EINVAL) instead. There is no silent truncation on this
firmware, and the universal claim in v1 was simply wrong.

Since I am withdrawing this series in favor of Dawid's upcoming RFC
(see the cover-letter thread), all of your feedback -- the
reverse-Christmas-tree sorting, the overflow-safe comparison form you
suggested (img_len > SZ_4G - img_phys), and reframing the 4 GiB check
as defensive hardening -- will go into a PR against his tree instead
of a v2 from me.

Best regards,
Haozhen Li


  reply	other threads:[~2026-11-02 16:27 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20261101160110.3622-1-dezige131@foxmail.com>
2026-11-01 16:01 ` Haozhen Li
2026-11-02 12:26   ` Konrad Dybcio
2026-11-02 16:27     ` Haozhen Li [this message]
2026-11-01 16:01 ` [RFC PATCH 2/2] firmware: qcom: scm: Handle QSEECOM listener callbacks Haozhen Li
2026-11-02 12:28   ` Konrad Dybcio
2026-11-02 16:27     ` Haozhen Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tencent_1A709D2F1A0F149D99E48871997B9FB32607@qq.com \
    --to=dezige131@foxmail.com \
    --cc=abelvesa@kernel.org \
    --cc=amirreza.zarrabi@oss.qualcomm.com \
    --cc=andersson@kernel.org \
    --cc=dmitry.baryshkov@oss.qualcomm.com \
    --cc=harshal.dev@oss.qualcomm.com \
    --cc=jorge.ramirez-ortiz@oss.qualcomm.com \
    --cc=konrad.dybcio@oss.qualcomm.com \
    --cc=konradybcio@kernel.org \
    --cc=kuldeep.singh@oss.qualcomm.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=me@dawidwrobel.com \
    --cc=sumit.garg@oss.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®