From: Zhang Shurong <zhang_shurong@foxmail.com>
To: sven@kernel.org
Cc: j@jannau.net, alyssa@rosenzweig.io, neal@gompa.dev,
joro@8bytes.org, will@kernel.org, robin.murphy@arm.com,
asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
iommu@lists.linux.dev, linux-kernel@vger.kernel.org,
Zhang Shurong <zhang_shurong@foxmail.com>
Subject: [PATCH] iommu/dart: add missing put_device() call in apple_dart_of_xlate
Date: Sun, 13 Jul 2025 00:16:24 +0800 [thread overview]
Message-ID: <tencent_22664B08ACDCE35DE10E5546C2FB26B59605@qq.com> (raw)
The apple_dart_of_xlate() function obtains a platform device reference
via of_find_device_by_node() but doesn't release it with put_device().
This patch adds proper device reference handling to prevent memory
leaks.
Fixes: 46d1fb072e76 ("iommu/dart: Add DART iommu driver")
Signed-off-by: Zhang Shurong <zhang_shurong@foxmail.com>
---
drivers/iommu/apple-dart.c | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/drivers/iommu/apple-dart.c b/drivers/iommu/apple-dart.c
index 190f28d76615..811bf5176568 100644
--- a/drivers/iommu/apple-dart.c
+++ b/drivers/iommu/apple-dart.c
@@ -796,8 +796,10 @@ static int apple_dart_of_xlate(struct device *dev,
if (!cfg) {
cfg = kzalloc(sizeof(*cfg), GFP_KERNEL);
- if (!cfg)
+ if (!cfg) {
+ put_device(&iommu_pdev->dev);
return -ENOMEM;
+ }
/* Will be ANDed with DART capabilities */
cfg->supports_bypass = true;
}
@@ -805,8 +807,10 @@ static int apple_dart_of_xlate(struct device *dev,
cfg_dart = cfg->stream_maps[0].dart;
if (cfg_dart) {
- if (cfg_dart->pgsize != dart->pgsize)
+ if (cfg_dart->pgsize != dart->pgsize) {
+ put_device(&iommu_pdev->dev);
return -EINVAL;
+ }
}
cfg->supports_bypass &= dart->supports_bypass;
@@ -825,6 +829,8 @@ static int apple_dart_of_xlate(struct device *dev,
}
}
+
+ put_device(&iommu_pdev->dev);
return -EINVAL;
}
--
2.39.5
next reply other threads:[~2025-07-12 16:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-12 16:16 Zhang Shurong [this message]
2025-07-12 18:22 ` Markus Elfring
2025-07-14 11:23 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tencent_22664B08ACDCE35DE10E5546C2FB26B59605@qq.com \
--to=zhang_shurong@foxmail.com \
--cc=alyssa@rosenzweig.io \
--cc=asahi@lists.linux.dev \
--cc=iommu@lists.linux.dev \
--cc=j@jannau.net \
--cc=joro@8bytes.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=neal@gompa.dev \
--cc=robin.murphy@arm.com \
--cc=sven@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®