mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: cjz_VM <guagua210311@qq.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: outreachy@lists.linux.dev, Vaibhav Agarwal <vaibhav.sr@gmail.com>,
	Mark Greer <mgreer@animalcreek.com>,
	Johan Hovold <johan@kernel.org>, Alex Elder <elder@kernel.org>,
	greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev,
	linux-kernel@vger.kernel.org, guagua210311@qq.com
Subject: Re: [PATCH] staging: greybus: audio_manager_module: make envp array static const
Date: Thu, 13 Nov 2025 21:39:54 +0800	[thread overview]
Message-ID: <tencent_27A546C0D8ACEF4B7DEE94D65FD805769809@qq.com> (raw)
In-Reply-To: <2025111341-attendee-ferment-262b@gregkh>

Hi Greg,

Thanks for reviewing my patch!

For sending twice: I apologize for the duplicate. After the first send, I realized I had missed some greybus-specific maintainers, so I resent to include them all.

For the indentation: You're right to ask about it. When I changed the declaration from 'char *envp[]' to 'static const char * const envp[]', the opening bracket moved to the right due to the longer declaration. I added tabs to keep the array elements aligned with the opening bracket, following the kernel coding style rule that parameters should align with the opening parenthesis.

If this alignment approach is not preferred, I'm happy to adjust it to whatever style you recommend.

Thanks again for your time and guidance!

Best regards,
Chang JunzhengFrom: cjz_VM <guagua210311@qq.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: outreachy@lists.linux.dev, Vaibhav Agarwal <vaibhav.sr@gmail.com>, Mark Greer <mgreer@animalcreek.com>, Johan Hovold <johan@kernel.org>, Alex Elder <elder@kernel.org>, greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, guagua210311@qq.com
Subject: Re: [PATCH] staging: greybus: audio_manager_module: make envp array static const
Reply-To: 
In-Reply-To: <2025111341-attendee-ferment-262b@gregkh>

Hi Greg,

Thanks for reviewing my patch!

For sending twice: I apologize for the duplicate. After the first send, I realized I had missed some greybus-specific maintainers, so I resent to include them all.

For the indentation: You're right to ask about it. When I changed the declaration from 'char *envp[]' to 'static const char * const envp[]', the opening bracket moved to the right due to the longer declaration. I added tabs to keep the array elements aligned with the opening bracket, following the kernel coding style rule that parameters should align with the opening parenthesis.

If this alignment approach is not preferred, I'm happy to adjust it to whatever style you recommend.

Thanks again for your time and guidance!

Best regards,
Chang Junzheng


  reply	other threads:[~2025-11-13 13:41 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-13 13:01 Chang Junzheng
2025-11-13 13:20 ` Greg Kroah-Hartman
2025-11-13 13:39   ` cjz_VM [this message]
2025-11-13 13:46     ` Greg Kroah-Hartman
  -- strict thread matches above, loose matches on Subject: below --
2025-11-13 12:52 Chang Junzheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tencent_27A546C0D8ACEF4B7DEE94D65FD805769809@qq.com \
    --to=guagua210311@qq.com \
    --cc=elder@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=greybus-dev@lists.linaro.org \
    --cc=johan@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=mgreer@animalcreek.com \
    --cc=outreachy@lists.linux.dev \
    --cc=vaibhav.sr@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®