mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Zhang Shurong <zhang_shurong@foxmail.com>
To: linux-wireless@vger.kernel.org, kernel-janitors@vger.kernel.org,
	Jakub Kicinski <kuba@kernel.org>, Kalle Valo <kvalo@kernel.org>,
	Ping-Ke Shih <pkshih@realtek.com>,
	Markus Elfring <Markus.Elfring@web.de>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] wifi: rtw89: debug: fix error code in rtw89_debug_priv_btc_manual_set
Date: Sat, 15 Jul 2023 17:56:10 +0800	[thread overview]
Message-ID: <tencent_283F851E543C098B9BC8DAA32D79B00A0F07@qq.com> (raw)
In-Reply-To: <a97b0b0c-8141-5391-727a-aa29fedc016b@web.de>

在 2023年7月15日星期六 CST 下午5:22:08,Markus Elfring 写道:
> > If there is a failure during kstrtobool_from_user()
> > rtw89_debug_priv_btc_manual_set should return negative error code
> > instead of returning the count driectly.
> > 
> > Fix this bug by returning the correct error code.
> 
> How do you think about to use an other wording approach
> (like the following) for an improved change description?
> 
> 
>   Return an error code instead of a count after a failed call
>   of the function “kstrtobool_from_user”.
>   Omit the label “out” with this source code correction.
> 
> 
> Regards,
> Markus
Thanks for your kindness reply and advice and I will change my description
in the next version.

Regards,
Shurong




      parent reply	other threads:[~2023-07-15  9:56 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-15  6:44 Zhang Shurong
     [not found] ` <a97b0b0c-8141-5391-727a-aa29fedc016b@web.de>
2023-07-15  9:56   ` Zhang Shurong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tencent_283F851E543C098B9BC8DAA32D79B00A0F07@qq.com \
    --to=zhang_shurong@foxmail.com \
    --cc=Markus.Elfring@web.de \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=kuba@kernel.org \
    --cc=kvalo@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=pkshih@realtek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®