mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Edward Adam Davis <eadavis@qq.com>
To: syzbot+0dcc341ee61fc9e4032f@syzkaller.appspotmail.com
Cc: linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com
Subject: Re: [syzbot] [usb?] INFO: task hung in dvb_usb_i2c_exit
Date: Tue, 13 May 2025 15:23:10 +0800	[thread overview]
Message-ID: <tencent_28E8E99AEDE2CD6079AA6C042DC96F34940A@qq.com> (raw)
In-Reply-To: <681688da.050a0220.11da1b.001c.GAE@google.com>

#syz test

diff --git a/drivers/media/usb/dvb-usb/cxusb.c b/drivers/media/usb/dvb-usb/cxusb.c
index f44529b40989..855d66043b85 100644
--- a/drivers/media/usb/dvb-usb/cxusb.c
+++ b/drivers/media/usb/dvb-usb/cxusb.c
@@ -1600,13 +1600,12 @@ static int cxusb_probe(struct usb_interface *intf,
 	struct dvb_usb_device *dvbdev;
 	int ret;
 
+	if (!cxusb_medion_check_intf(intf))
+		return -ENODEV;
+
 	/* Medion 95700 */
 	if (!dvb_usb_device_init(intf, &cxusb_medion_properties,
 				 THIS_MODULE, &dvbdev, adapter_nr)) {
-		if (!cxusb_medion_check_intf(intf)) {
-			ret = -ENODEV;
-			goto ret_uninit;
-		}
 
 		_cxusb_power_ctrl(dvbdev, 1);
 		ret = cxusb_medion_set_mode(dvbdev, false);


  parent reply	other threads:[~2025-05-13  7:31 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-03 21:21 syzbot
2025-05-13  6:50 ` Edward Adam Davis
2025-05-13  7:20   ` syzbot
2025-05-13  7:23 ` Edward Adam Davis [this message]
2025-05-13 18:26   ` syzbot
2025-05-13 23:01 ` [PATCH] media: cxusb: Initialize medion after checking intf Edward Adam Davis
     [not found] <20250503231531.1578-1-hdanton@sina.com>
2025-05-04  1:44 ` [syzbot] [usb?] INFO: task hung in dvb_usb_i2c_exit syzbot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tencent_28E8E99AEDE2CD6079AA6C042DC96F34940A@qq.com \
    --to=eadavis@qq.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=syzbot+0dcc341ee61fc9e4032f@syzkaller.appspotmail.com \
    --cc=syzkaller-bugs@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®