From: Zhao Dongdong <winter91@foxmail.com>
To: p.zabel@pengutronix.de, wens@kernel.org, jernej.skrabec@gmail.com
Cc: linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org,
Zhao Dongdong <zhaodongdong@kylinos.cn>,
stable@vger.kernel.org
Subject: [PATCH] reset: sunxi: fix memory region leak on ioremap failure
Date: Wed, 17 Jun 2026 11:16:27 +0800 [thread overview]
Message-ID: <tencent_2C7697B076D53BBE62D99B7CD15E77A20C07@qq.com> (raw)
From: Zhao Dongdong <zhaodongdong@kylinos.cn>
In sunxi_reset_init(), when ioremap() fails, the memory region obtained
via request_mem_region() is not released, leading to a resource leak.
Add an err_mem_region label to properly release the memory region before
freeing the data structure.
Fixes: 8f1ae77f4666 ("reset: Add Allwinner SoCs Reset Controller Driver")
Cc: stable@vger.kernel.org
Signed-off-by: Zhao Dongdong <zhaodongdong@kylinos.cn>
---
drivers/reset/reset-sunxi.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/reset/reset-sunxi.c b/drivers/reset/reset-sunxi.c
index 2544de6576e4..2f6df7707cad 100644
--- a/drivers/reset/reset-sunxi.c
+++ b/drivers/reset/reset-sunxi.c
@@ -44,7 +44,7 @@ static int sunxi_reset_init(struct device_node *np)
data->membase = ioremap(res.start, size);
if (!data->membase) {
ret = -ENOMEM;
- goto err_alloc;
+ goto err_mem_region;
}
spin_lock_init(&data->lock);
@@ -57,6 +57,8 @@ static int sunxi_reset_init(struct device_node *np)
return reset_controller_register(&data->rcdev);
+err_mem_region:
+ release_mem_region(res.start, size);
err_alloc:
kfree(data);
return ret;
--
2.25.1
next reply other threads:[~2026-06-17 3:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-17 3:16 Zhao Dongdong [this message]
2026-06-17 17:09 ` Jernej Škrabec
2026-06-18 9:49 ` Philipp Zabel
2026-07-02 15:53 ` Philipp Zabel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tencent_2C7697B076D53BBE62D99B7CD15E77A20C07@qq.com \
--to=winter91@foxmail.com \
--cc=jernej.skrabec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=p.zabel@pengutronix.de \
--cc=stable@vger.kernel.org \
--cc=wens@kernel.org \
--cc=zhaodongdong@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®