From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752092AbdKMIh0 (ORCPT <rfc822;w@1wt.eu>);
        Mon, 13 Nov 2017 03:37:26 -0500
Received: from smtpbg65.qq.com ([103.7.28.233]:35829 "EHLO smtpbg65.qq.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751980AbdKMIhY (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 13 Nov 2017 03:37:24 -0500
X-QQ-GoodBg: 0
X-QQ-SSF: 00100000000000F0
X-QQ-FEAT: CaOyJLkxpPnI7YsLHOi3O6KFMVy7E4ZXjDoSstQfn54Kr2q57QefbRpouNlQ9
        N69C4u/1ixN5c7wWSbAOloMQtP0fAF43uHTdJK6xJxxGfhKCiqJeQA5I0fwuCULpAhDvCMk
        qHM3rq+F4FE2hP1eT/IQdjwiCqfEsrIEIbyMq06s2b1RHXQA+jP33jyXnVQrYMD7ITqEBQ5
        Skp4wl1g2mMwYPwQ2rKw8SexLBfzAXOQ3h31jcTJ8YBWPrTlBOghtQKGnjgx8lEbuJEhD6f
        vUoXq/SAzDxxLVU5vpnFsa6DhjTSxiusv40w==
X-QQ-BUSINESS-ORIGIN: 2
X-Originating-IP: 222.92.124.153
X-QQ-STYLE: 
X-QQ-mid: bizmailfree34t1510562229t1275
From: "=?utf-8?B?6ZmI5Y2O5omN?=" <chenhc@lemote.com>
To: "=?utf-8?B?Q2hyaXN0b3BoIEhlbGx3aWc=?=" <hch@lst.de>
Cc: "=?utf-8?B?Q2hyaXN0b3BoIEhlbGx3aWc=?=" <hch@lst.de>,
        "=?utf-8?B?TWFyZWsgU3p5cHJvd3NraQ==?=" <m.szyprowski@samsung.com>,
        "=?utf-8?B?Um9iaW4gTXVycGh5?=" <robin.murphy@arm.com>,
        "=?utf-8?B?QW5kcmV3IE1vcnRvbg==?=" <akpm@linux-foundation.org>,
        "=?utf-8?B?RnV4aW4gWmhhbmc=?=" <zhangfx@lemote.com>,
        "=?utf-8?B?bGludXgta2VybmVs?=" <linux-kernel@vger.kernel.org>,
        "=?utf-8?B?UmFsZiBCYWVjaGxl?=" <ralf@linux-mips.org>,
        "=?utf-8?B?SmFtZXMgSG9nYW4=?=" <james.hogan@imgtec.com>,
        "=?utf-8?B?bGludXgtbWlwcw==?=" <linux-mips@linux-mips.org>,
        "=?utf-8?B?SmFtZXMgRSAuIEogLiBCb3R0b21sZXk=?=" 
        <jejb@linux.vnet.ibm.com>,
        "=?utf-8?B?TWFydGluIEsgLiBQZXRlcnNlbg==?=" 
        <martin.petersen@oracle.com>,
        "=?utf-8?B?bGludXgtc2NzaQ==?=" <linux-scsi@vger.kernel.org>,
        "=?utf-8?B?c3RhYmxl?=" <stable@vger.kernel.org>,
        "=?utf-8?B?TWljaGFlbCBTIC4gVHNpcmtpbg==?=" <mst@redhat.com>,
        "=?utf-8?B?UGF3ZWwgT3NjaWFr?=" <pawel@osciak.com>,
        "=?utf-8?B?S3l1bmdtaW4gUGFyaw==?=" <kyungmin.park@samsung.com>,
        "=?utf-8?B?TWljaGFlbCBDaGFu?=" <michael.chan@broadcom.com>,
        "=?utf-8?B?QmVuamFtaW4gSGVycmVuc2NobWlkdA==?=" 
        <benh@kernel.crashing.org>,
        "=?utf-8?B?SXZhbiBNaWtoYXlsb3Y=?=" <ivan@ru.ibm.com>,
        "=?utf-8?B?VGFyaXEgVG91a2Fu?=" <tariqt@mellanox.com>,
        "=?utf-8?B?QW5keSBHcm9zcw==?=" <agross@codeaurora.org>,
        "=?utf-8?B?TWFyayBBIC4gR3JlZXI=?=" <mgreer@animalcreek.com>,
        "=?utf-8?B?Um9iZXJ0IEJhbGR5Z2E=?=" <r.baldyga@hackerion.com>
Subject: Re: [PATCH V9 1/4] dma-mapping: Rework dma_get_cache_alignment()
Mime-Version: 1.0
Content-Type: text/plain;
        charset="utf-8"
Date: Mon, 13 Nov 2017 16:37:09 +0800
X-Priority: 3
Message-ID: <tencent_2CE7124212471D7F3E9CA16E@qq.com>
X-QQ-MIME: TCMime 1.0 by Tencent
X-Mailer: QQMail 2.x
X-QQ-Mailer: QQMail 2.x
References: <1508742767-28366-1-git-send-email-chenhc@lemote.com>
        <20171110123059.GA9296@lst.de>
In-Reply-To: <20171110123059.GA9296@lst.de>
X-QQ-ReplyHash: 3445912182
X-QQ-SENDSIZE: 520
Feedback-ID: bizmailfree:lemote.com:qybgforeign:qybgforeign1
X-QQ-Bgrelay: 1
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from base64 to 8bit by nfs id vAD8bWJa026244

But in b44_init(), there is no device instances.
 
 
 
------------------ Original ------------------
From:  "Christoph Hellwig"<hch@lst.de>;
Date:  Fri, Nov 10, 2017 08:30 PM
To:  "Huacai Chen"<chenhc@lemote.com>; 
Cc:  "Christoph Hellwig"<hch@lst.de>; "Marek Szyprowski"<m.szyprowski@samsung.com>; "Robin Murphy"<robin.murphy@arm.com>; "Andrew Morton"<akpm@linux-foundation.org>; "Fuxin Zhang"<zhangfx@lemote.com>; "linux-kernel"<linux-kernel@vger.kernel.org>; "Ralf Baechle"<ralf@linux-mips.org>; "James Hogan"<james.hogan@imgtec.com>; "linux-mips"<linux-mips@linux-mips.org>; "James E . J . Bottomley"<jejb@linux.vnet.ibm.com>; "Martin K . Petersen"<martin.petersen@oracle.com>; "linux-scsi"<linux-scsi@vger.kernel.org>; "stable"<stable@vger.kernel.org>; "Michael S . Tsirkin"<mst@redhat.com>; "Pawel Osciak"<pawel@osciak.com>; "Kyungmin Park"<kyungmin.park@samsung.com>; "Michael Chan"<michael.chan@broadcom.com>; "Benjamin Herrenschmidt"<benh@kernel.crashing.org>; "Ivan Mikhaylov"<ivan@ru.ibm.com>; "Tariq Toukan"<tariqt@mellanox.com>; "Andy Gross"<agross@codeaurora.org>; "Mark A . Greer"<mgreer@animalcreek.com>; "Robert Baldyga"<r.baldyga@hackerion.com>; 
Subject:  Re: [PATCH V9 1/4] dma-mapping: Rework dma_get_cache_alignment()

 
> diff --git a/drivers/net/ethernet/broadcom/b44.c b/drivers/net/ethernet/broadcom/b44.c
> index a1125d1..2f6ffe5 100644
> --- a/drivers/net/ethernet/broadcom/b44.c
> +++ b/drivers/net/ethernet/broadcom/b44.c
> @@ -2344,6 +2344,10 @@ static int b44_init_one(struct ssb_device *sdev,
>  	struct net_device *dev;
>  	struct b44 *bp;
>  	int err;
> +	unsigned int dma_desc_align_size = dma_get_cache_alignment(sdev->dma_dev);
> +
> +	/* Setup paramaters for syncing RX/TX DMA descriptors */
> +	dma_desc_sync_size = max_t(unsigned int, dma_desc_align_size, sizeof(struct dma_desc));
>  
>  	instance++;
>  
> @@ -2587,12 +2591,8 @@ static inline void b44_pci_exit(void)
>  
>  static int __init b44_init(void)
>  {
> -	unsigned int dma_desc_align_size = dma_get_cache_alignment();
>  	int err;
>  
> -	/* Setup paramaters for syncing RX/TX DMA descriptors */
> -	dma_desc_sync_size = max_t(unsigned int, dma_desc_align_size, sizeof(struct dma_desc));
> -

This looks wrong - you override a global variable for each probed
device.