From: cjz <guagua210311@qq.com>
To: gregkh@linuxfoundation.org
Cc: linux-kernel@vger.kernel.org, changjunzheng <guagua210311@qq.com>
Subject: [PATCH] rtl8723bs: Replace atomic_t with int for continual_io_error (no concurrency)
Date: Thu, 18 Dec 2025 22:16:55 +0800 [thread overview]
Message-ID: <tencent_2E2DEECAD73FD8A5773CA4CAC11AAC3D4A09@qq.com> (raw)
From: changjunzheng <guagua210311@qq.com>
The 'continual_io_error' variable is defined as atomic_t, but all call sites
of rtw_inc_and_chk_continual_io_error/rtw_reset_continual_io_error are in
process context (sdio_ops_linux.c/sdio_intf.c, SDIO read/write retry logic).
There is no interrupt/thread concurrency modifying this variable, so atomic
operations are unnecessary and introduce slight performance overhead.
This change replaces atomic_t with a normal int, and replaces atomic_inc_return()/atomic_set()
with ordinary increment/assignment, keeping all functional logic unchanged.
Signed-off-by: changjunzheng <guagua210311@qq.com>
---
drivers/staging/rtl8723bs/core/rtw_io.c | 10 +++-------
drivers/staging/rtl8723bs/include/drv_types.h | 2 +-
2 files changed, 4 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_io.c b/drivers/staging/rtl8723bs/core/rtw_io.c
index fe9f94001eed..0f52710e6d3a 100644
--- a/drivers/staging/rtl8723bs/core/rtw_io.c
+++ b/drivers/staging/rtl8723bs/core/rtw_io.c
@@ -139,16 +139,12 @@ int rtw_init_io_priv(struct adapter *padapter, void (*set_intf_ops)(struct adapt
*/
int rtw_inc_and_chk_continual_io_error(struct dvobj_priv *dvobj)
{
- int error_count = atomic_inc_return(&dvobj->continual_io_error);
-
- if (error_count > MAX_CONTINUAL_IO_ERR)
- return true;
-
- return false;
+ dvobj->continual_io_error++;
+ return (dvobj->continual_io_error > MAX_CONTINUAL_IO_ERR);
}
/* Set the continual_io_error of this @param dvobjprive to 0 */
void rtw_reset_continual_io_error(struct dvobj_priv *dvobj)
{
- atomic_set(&dvobj->continual_io_error, 0);
+ dvobj->continual_io_error = 0;
}
diff --git a/drivers/staging/rtl8723bs/include/drv_types.h b/drivers/staging/rtl8723bs/include/drv_types.h
index f86180dc350c..bd7bb5828d56 100644
--- a/drivers/staging/rtl8723bs/include/drv_types.h
+++ b/drivers/staging/rtl8723bs/include/drv_types.h
@@ -279,7 +279,7 @@ struct dvobj_priv {
u8 Queue2Pipe[HW_QUEUE_ENTRY];/* for out pipe mapping */
u8 irq_alloc;
- atomic_t continual_io_error;
+ int continual_io_error;
atomic_t disable_func;
--
2.43.0
next reply other threads:[~2025-12-18 14:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-18 14:16 cjz [this message]
2025-12-18 14:37 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tencent_2E2DEECAD73FD8A5773CA4CAC11AAC3D4A09@qq.com \
--to=guagua210311@qq.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®