From: Yuwen Chen <ywen.chen@foxmail.com>
To: tglx@kernel.org
Cc: akpm@linux-foundation.org, andrealmeid@igalia.com,
bigeasy@linutronix.de, colin.i.king@gmail.com, dave@stgolabs.net,
dvhart@infradead.org, edliaw@google.com, justinstitt@google.com,
kernel-team@android.com, licayy@foxmail.com,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
luto@mit.edu, mingo@redhat.com, morbo@google.com,
nathan@kernel.org, ndesaulniers@google.com, peterz@infradead.org,
shuah@kernel.org, usama.anjum@collabora.com, wakel@google.com,
ywen.chen@foxmail.com
Subject: Re: [PATCH v2] selftests/futex: fix the failed futex_requeue test issue
Date: Wed, 28 Jan 2026 11:29:51 +0800 [thread overview]
Message-ID: <tencent_347CD8D5F7FC23EFE58BBACBA98894DB6E05@qq.com> (raw)
In-Reply-To: <878qdic3i0.ffs@tglx>
On Tue, 27 Jan 2026 19:30:31 +0100, Thomas Gleixner wrote:
> Extremely high?
>
> The main thread waits for 10000us aka. 10 seconds to allow the waiter
> thread to reach futex_wait().
>
> If anything is extreme then it's the 10 seconds wait, not the
> requirements. Please write factual changelogs and not fairy tales.
10,000 us is equal to 10 ms. On a specific ARM64 platform, it's quite
common for this test case to fail when there is a 10-millisecond waiting
time.
> That's a known issue for all futex selftests when the test system is
> under extreme load. That's why there is a gratious 10 seconds timeout,
> which is annoyingly long already.
>
> Also why is this special for the requeue_single test case?
>
> It's exactly the same issue for all futex selftests including the multi
> waiter one in the very same file, no?
Yes, this is a common phenomenon. However, for the sake of convenient
illustration, only the case of requeue_single is listed here.
> Why do you need an atomic store here?
>
> pthread_barrier_wait() is a full memory barrier already, no?
Yes, there's no need to use atomic here. However, in the kernel, WRITE_ONCE
and READ_ONCE are more likely to be used. Since it's particularly difficult
to use them here, atomic is adopted.
> What's wrong with reading /proc/$PID/wchan ?
>
> It's equally unreliable as /proc/$PID/stat because both can return the
> desired state _before_ the thread reaches the inner workings of the test
> related sys_futex(... WAIT).
Is it possible for the waiterfn to enter the sleep state between the
pthread_barrier_wait function and the futex_wait function? If so, would
checking the call stack be a solution?
Maybe using /proc/$PID/wchan is a better approach. Currently, I haven't found
any problems when using /proc/$PID/stat on our platform.
Thanks
Yuwen
next prev parent reply other threads:[~2026-01-28 3:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-26 9:33 Yuwen Chen
2026-01-27 18:30 ` Thomas Gleixner
2026-01-28 3:29 ` Yuwen Chen [this message]
2026-01-28 8:36 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tencent_347CD8D5F7FC23EFE58BBACBA98894DB6E05@qq.com \
--to=ywen.chen@foxmail.com \
--cc=akpm@linux-foundation.org \
--cc=andrealmeid@igalia.com \
--cc=bigeasy@linutronix.de \
--cc=colin.i.king@gmail.com \
--cc=dave@stgolabs.net \
--cc=dvhart@infradead.org \
--cc=edliaw@google.com \
--cc=justinstitt@google.com \
--cc=kernel-team@android.com \
--cc=licayy@foxmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=luto@mit.edu \
--cc=mingo@redhat.com \
--cc=morbo@google.com \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=peterz@infradead.org \
--cc=shuah@kernel.org \
--cc=tglx@kernel.org \
--cc=usama.anjum@collabora.com \
--cc=wakel@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®