From: "Cunhao Lu" <1579567540@qq.com>
To: "Quentin Schulz" <quentin.schulz@cherry.de>,
"Marc Kleine-Budde" <mkl@pengutronix.de>,
kernel <kernel@pengutronix.de>,
"Vincent Mailhol" <mailhol@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Heiko Stuebner" <heiko@sntech.de>
Cc: linux-can <linux-can@vger.kernel.org>,
devicetree <devicetree@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
linux-rockchip <linux-rockchip@lists.infradead.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
"Heiko Stuebner" <heiko.stuebner@cherry.de>
Subject: Re: [PATCH v5 4/4] arm64: dts: rockchip: Enable CAN controller on RK3588-Tiger-Haikou
Date: Thu, 30 Jul 2026 22:04:43 +0800 [thread overview]
Message-ID: <tencent_34D00CC80826788DD404902246F9ED36E10A@qq.com> (raw)
In-Reply-To: <7628bc49-b4e7-4716-9579-022c20bbf134@cherry.de>
Hi Quentin,
> Can you please move the assigned-clocks* properties to rk3588-tiger.dtsi
> instead? RK3588 Tiger is a SOM and Haikou is a carrierboard. The
> carrierboard takes the signal directly from the SoC and route those to a
> transceiver. I'm assuming all carrierboards for Tiger will need those
> two properties, so better have them in the SoM DTSI.
>
> on top of this patch and squash and we'll have what I would like to have.
>
> If there's no need for a v6, I'm assuming Heiko can simply fix that when
> applying and thus there may be no need to send a v6 just for that (but
> if you need to send a v6, please consider doing the suggested changes
> above).
I will move the assigned-clocks and assigned-clock-rates properties to
rk3588-tiger.dtsi. I am preparing v6 now and will post it
shortly with these changes.
Thanks,
Cunhao
prev parent reply other threads:[~2026-07-30 14:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20260725-master-v5-0-75da459d2b93@qq.com>
2026-07-25 7:03 ` [PATCH v5 1/4] dt-bindings: can: rockchip: add rk3588 CAN-FD compatible Cunhao Lu
2026-07-25 7:03 ` [PATCH v5 2/4] can: rockchip: add RK3588 CAN support Cunhao Lu
2026-07-25 7:03 ` [PATCH v5 3/4] arm64: dts: rockchip: add CAN-FD nodes for RK3588 Cunhao Lu
2026-07-30 13:22 ` Quentin Schulz
2026-07-30 14:03 ` Cunhao Lu
2026-07-30 14:13 ` Marc Kleine-Budde
2026-07-25 7:03 ` [PATCH v5 4/4] arm64: dts: rockchip: Enable CAN controller on RK3588-Tiger-Haikou Cunhao Lu
2026-07-30 13:31 ` Quentin Schulz
2026-07-30 14:04 ` Cunhao Lu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tencent_34D00CC80826788DD404902246F9ED36E10A@qq.com \
--to=1579567540@qq.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=heiko.stuebner@cherry.de \
--cc=heiko@sntech.de \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mailhol@kernel.org \
--cc=mkl@pengutronix.de \
--cc=quentin.schulz@cherry.de \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®