From: Edward Adam Davis <eadavis@qq.com>
To: syzbot+1fed2de07d8e11a3ec1b@syzkaller.appspotmail.com
Cc: linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com
Subject: Re: [syzbot] [ocfs2?] possible deadlock in ocfs2_try_remove_refcount_tree
Date: Wed, 21 Aug 2024 17:32:16 +0800 [thread overview]
Message-ID: <tencent_3BC9CCA2E7ED86CB52D9C66449BE2EC72E06@qq.com> (raw)
In-Reply-To: <00000000000032dd730620055fde@google.com>
use trylock to replace
#syz test: upstream 1fb918967b56
diff --git a/fs/ocfs2/acl.c b/fs/ocfs2/acl.c
index 62464d194da3..f60e3178fe74 100644
--- a/fs/ocfs2/acl.c
+++ b/fs/ocfs2/acl.c
@@ -363,7 +363,8 @@ int ocfs2_init_acl(handle_t *handle,
if (!S_ISLNK(inode->i_mode)) {
if (osb->s_mount_opt & OCFS2_MOUNT_POSIX_ACL) {
- down_read(&OCFS2_I(dir)->ip_xattr_sem);
+ if (!down_read_trylock(&OCFS2_I(dir)->ip_xattr_sem))
+ return -EBUSY;
acl = ocfs2_get_acl_nolock(dir, ACL_TYPE_DEFAULT,
dir_bh);
up_read(&OCFS2_I(dir)->ip_xattr_sem);
next prev parent reply other threads:[~2024-08-21 9:37 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-19 8:48 syzbot
2024-08-21 9:32 ` Edward Adam Davis [this message]
2024-08-21 9:48 ` syzbot
2024-08-21 21:04 ` [syzbot] " syzbot
2025-06-21 16:03 ` Tetsuo Handa
2025-07-14 21:57 ` Tetsuo Handa
2024-09-23 22:04 ` [syzbot] [ocfs2?] " syzbot
2025-06-21 14:27 ` Tetsuo Handa
2025-06-21 15:05 ` syzbot
2025-07-19 17:11 ` Forwarded: " syzbot
[not found] <20240821210432.146003-1-djahchankoike@gmail.com>
2024-08-21 21:20 ` syzbot
[not found] <690ae6be-8313-46eb-a546-b895f5a7227c@I-love.SAKURA.ne.jp>
2025-07-19 18:22 ` syzbot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tencent_3BC9CCA2E7ED86CB52D9C66449BE2EC72E06@qq.com \
--to=eadavis@qq.com \
--cc=linux-kernel@vger.kernel.org \
--cc=syzbot+1fed2de07d8e11a3ec1b@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®