From: Haobin Jiang <lemonoutput@foxmail.com>
To: carlos.song@oss.nxp.com
Cc: Frank.Li@nxp.com, andi.shyti@kernel.org, dillon.minfei@gmail.com,
festevam@gmail.com, imx@lists.linux.dev, kernel@pengutronix.de,
lemonoutput@foxmail.com, linux-arm-kernel@lists.infradead.org,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
o.rempel@pengutronix.de, s.hauer@pengutronix.de, vjardin@free.fr
Subject: Re: [PATCH v5] i2c: imx: honour I2C_M_IGNORE_NAK
Date: Thu, 5 Nov 2026 17:39:09 +0800 [thread overview]
Message-ID: <tencent_3D65EAC95AB758A272F0ABB30C86ECE2A205@qq.com> (raw)
In-Reply-To: <93667d47-794c-45d1-b72a-a463d5289a29@oss.nxp.com>
Hi Carlos,
> Why not follow community rule to make patch...?
You are right, and thank you for taking the time to point it out.
> At higher version, better commit log and put change to commit log bottom
> with extra lines like your V3 patch[2].
Agreed. When I prepared V5, I regenerated the log from the current diff
and did not carry forward the problem description, the test evidence, or
the review history from V2/V3/V4. That is my responsibility as the
submitter.
> I think V5 patch commit log should be better with shorter and clearer
> problem description, reproduction, resolution, verification based on V2
> patch[1] and V3 patch[2].
I will rewrite it that way for V6. The commit log will cover the
problem, the resolution, the reproduction/verification, and the review
history with links to V1-V5. I will put the changelog below a single
`---` line, like V3.
> But abviously, this patch is generated by AI, and it dropped most commit
> and discussion details from previous patches.
That is a fair criticism of V5. The tool produced a shorter log; I should
have caught that before sending. I will restore the AI-assistance note
from V3/V4 and describe which parts were tool-assisted and how I verified
them. I will not resend until the V6 log is self-contained and I have
re-checked the new zero-length guard. I will state clearly what was and
was not tested.
One point I want to be explicit about: the V5 guard only rejects
I2C_M_RD + I2C_M_IGNORE_NAK + len == 0. It does not fix the pre-existing
unflagged zero-length read path. That scope is a deliberate choice, and
I will document it in V6 rather than imply the general issue is fixed.
> AI-generated patches should be subject to more rigorous review and
> testing... humans must always remain in control in whole flow.
Understood. I will keep the human review and test evidence in the
changelog, and I will be the one accountable for the content.
Thanks,
Haobin
prev parent reply other threads:[~2026-11-05 9:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-28 6:33 Haobin Jiang
2026-11-05 7:59 ` Carlos Song
2026-11-05 9:39 ` Haobin Jiang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tencent_3D65EAC95AB758A272F0ABB30C86ECE2A205@qq.com \
--to=lemonoutput@foxmail.com \
--cc=Frank.Li@nxp.com \
--cc=andi.shyti@kernel.org \
--cc=carlos.song@oss.nxp.com \
--cc=dillon.minfei@gmail.com \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=s.hauer@pengutronix.de \
--cc=vjardin@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®