mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Rong Tao <rtoax@foxmail.com>
To: olsajiri@gmail.com
Cc: andrii@kernel.org, ast@kernel.org, bpf@vger.kernel.org,
	daniel@iogearbox.net, haoluo@google.com,
	john.fastabend@gmail.com, kpsingh@kernel.org,
	linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
	martin.lau@linux.dev, mykolal@fb.com, rongtao@cestc.cn,
	rtoax@foxmail.com, sdf@google.com, shuah@kernel.org,
	song@kernel.org, yonghong.song@linux.dev
Subject: Re: [PATCH bpf-next v6] selftests/bpf: trace_helpers.c: optimize kallsyms cache
Date: Tue, 22 Aug 2023 08:38:58 +0800	[thread overview]
Message-ID: <tencent_492BE2E81E62BEC199106096C025954AFD06@qq.com> (raw)
In-Reply-To: <ZOMiqE0QY2Lrw2UC@krava>

> I think you need to fix this on samples/bpf side
> 
> I tried to play with the samples/bpf/ includes, but couldn't find a way to
> make this work.. selftests base includes on tools/include, while samples
> have $(objtree)/usr/include as first include and AFAICS the __must_check is
> defined under __KERNEL__ ifdef
> 
> I guess the reason samples use $(objtree)/usr/include is to get some struct
> definitions which are not in tools/include, but looks like some samples objects
> already use vmlinux.h include, so that could be the way forward to fix that

I tried the method you suggested, and some unexpected problems occurred. Maybe,
we can apply v5 [0] first, and then solve this problem?

Best wishes,
Rong Tao

[0] v5: https://lore.kernel.org/lkml/tencent_0E9E1A1C0981678D5E7EA9E4BDBA8EE2200A@qq.com/


  reply	other threads:[~2023-08-22  0:50 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-21  6:45 Rong Tao
2023-08-21  8:39 ` Jiri Olsa
2023-08-22  0:38   ` Rong Tao [this message]
2023-08-25  9:08     ` Jiri Olsa
2023-08-25 10:40       ` Rong Tao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tencent_492BE2E81E62BEC199106096C025954AFD06@qq.com \
    --to=rtoax@foxmail.com \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=haoluo@google.com \
    --cc=john.fastabend@gmail.com \
    --cc=kpsingh@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=martin.lau@linux.dev \
    --cc=mykolal@fb.com \
    --cc=olsajiri@gmail.com \
    --cc=rongtao@cestc.cn \
    --cc=sdf@google.com \
    --cc=shuah@kernel.org \
    --cc=song@kernel.org \
    --cc=yonghong.song@linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®