From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from xmbghk7.mail.qq.com (xmbghk7.mail.qq.com [43.163.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AE8CF17B505 for ; Mon, 10 Aug 2026 01:24:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=43.163.128.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786325075; cv=none; b=KXLhd637nTIApjr3kIMUTI19nLDPOXAU5QMTeYjn+87ngGzFaqUU+uCDQJ8OtAeTYZUMUc1KLLz7Wjjopn4eg4pCiY4ts/FCJgJYgt1YNSVzyBxPvYV5Fviw6L1miC1nDxWuTXbV+s+qidI6zqijfXn6PSnyRAtulTswfKeIzvc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786325075; c=relaxed/simple; bh=kZ5QProgkxQqrYfFxY1vUlbwoZfGUi6mjQP2dRKYdx8=; h=Message-ID:From:To:Cc:Subject:Date:In-Reply-To:References: MIME-Version; b=M1hNTFsnRZcsxMBp8/citWpoPiVkhDY9Maqxa+jQ1zOERw7f4CKlzebWG2CWqyOPbkIY+4aee5SWq1Ybyx4x8vJiojUW8KiLz1k+R/rJViZuW8r2gIcvlHwUNR87v7BLlN5qqeDfCNR44NJbzSL0HcLMee7DBH8qOjXXmtPvYyE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=qq.com; spf=pass smtp.mailfrom=qq.com; dkim=pass (1024-bit key) header.d=qq.com header.i=@qq.com header.b=VdUyi332; arc=none smtp.client-ip=43.163.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=qq.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=qq.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=qq.com header.i=@qq.com header.b="VdUyi332" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qq.com; s=s201512; t=1786325063; bh=aSK/5mU5rqk4pj4igZjhodDn9X/fm4utvzW/kNGw9yo=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=VdUyi332zHQ8fHQqaAd29nEwEf1uy8hlViYGOu3Qv9VNAUca70aoIV1IKeyWzsDao 95WvQ0hlafPnzImQyQBYTB+spLY6e2oBZdQsitninysDLG8yKATkWHBP+AJHhKD5F/ qVr+FRzdZX1y4dkdowIHsalx2ZsvywtQfNV1Z8t0= Received: from lxu-ped-host.. ([111.198.231.89]) by newxmesmtplogicsvrsza73-0.qq.com (NewEsmtp) with SMTP id 61510012; Mon, 10 Aug 2026 09:24:21 +0800 X-QQ-mid: xmsmtpt1786325061to2s3u9o8 Message-ID: X-QQ-XMAILINFO: N/+CYpjGFRvWokzENW46QYwW6PFVSov2iA6CTj5kkWrbVhFlNZVuLZ7tCS2nPC 4m+uno5oqcncrMwYRLMd4bChKpltOV/kK7WzvcBa4EeUOKM2GLcb6PrPLrAN28c2W0QhpHpUS7Tb xQ/GFMvA3GZqWXHey4x0c7HERfpyoOosmscXMeU5ooQiF6u0G/2YxdrRZOC2Dbzl9WA/unI+umcn kt28J7CaTvM/0zddPa56ojRfHmuAhv+Meiw1/FuQKWYkziueFw7uwkPKAoeZCvUIumIBcK6ZG9BV WUslyrg9j2vygoFkCY895AYfXI90tJCgU2nixFIiPh/XskCZY32edIJ6W8K2ytryFQpiAP7bIswn XMbb/YuN0HK1rqudv3I0EkqDOaKQKh4xtQApq24s8ZZnbhvQm6yuOxLgNJohccqZdgpr+hzUdzN9 Eu/Lvu8kd3oIUJMml9XH63MuOMPronWYwILwnJeiSeBRliLxniyIXQ21MoRBUyKwunXUo1WtvkpX 98fg8Dej3O+4usyfXnux7+WCoahaJwbHTnwtCfRoMMi/G7SeVpiImjahRN0kruX4fPOcxvP/G3Hf LBoyV/m5Y4ghhP426bj1tCSdhqZB/aSM5zhlwPelzAZ56H+22PzMHgvSujOZjSOR3nDmhHejkqpk dC63f+WHIDI5uGMxJPjWbpyanmgj/HvTE419ruLt+GaEvat3/fgZ7kEljK2YX4a13od/fi3vm/D1 VX2/hZfdswcTtkMJsgWnynGi7SzXy918rq37GFDOCSSNTwa6e7cfHtKu0TsoVs1X0mveqUpWk7Jm z7Wf/BSsdF9RPx8KJJCZFozL200wQx7rPUzl6/lvZ/+DnUOjmyHFGHf+NOg9Mml/xhJX42o+8QN0 gRt9qdQ9uuPRJUyl0Epvml0kHLC73FLmZz3UQMAPtK56ayTOt/4oHD9Vw5BV4gTCo9CUfSDC+LGV /fS1URfOKhP4AExmyBQobjoaQq4K3wWW8sBtDZJAnMnQyPAxf09WWBHvVbHMumiJBftsiwO0w= X-QQ-XMRINFO: Mp0Kj//9VHAxzExpfF+O8yhSrljjwrznVg== From: Edward Adam Davis To: syzbot+60740c6a17a5b5eb1f5a@syzkaller.appspotmail.com Cc: linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com Subject: Re: [syzbot] [usb?] memory leak in hidg_bind Date: Mon, 10 Aug 2026 09:24:21 +0800 X-OQ-MSGID: <20260810012420.48786-2-eadavis@qq.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <6a78d160.01d0871a.3a0d52.0091.GAE@google.com> References: <6a78d160.01d0871a.3a0d52.0091.GAE@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit #syz test diff --git a/drivers/usb/gadget/function/f_hid.c b/drivers/usb/gadget/function/f_hid.c index 3c6b43d06a6d..0aa14b99d97e 100644 --- a/drivers/usb/gadget/function/f_hid.c +++ b/drivers/usb/gadget/function/f_hid.c @@ -1163,8 +1163,10 @@ static int hidg_bind(struct usb_configuration *c, struct usb_function *f) /* maybe allocate device-global string IDs, and patch descriptors */ us = usb_gstrings_attach(c->cdev, ct_func_strings, ARRAY_SIZE(ct_func_string_defs)); - if (IS_ERR(us)) - return PTR_ERR(us); + if (IS_ERR(us)) { + status = PTR_ERR(us); + goto fail; + } hidg_interface_desc.iInterface = us[CT_FUNC_HID_IDX].id; /* allocate instance-specific interface IDs, and patch descriptors */