mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: xkeyC <xkeyc@qq.com>
To: liubaolin <liubaolin12138@163.com>
Cc: Namjae Jeon <linkinjeon@kernel.org>,
	Hyunchul Lee <hyc.lee@gmail.com>,
	ntfs@lists.linux.dev, linux-kernel@vger.kernel.org,
	stable@vger.kernel.org
Subject: Re: [PATCH v2] ntfs: don't let a fatal signal interrupt metadata reads
Date: Thu, 12 Nov 2026 15:05:29 +0800	[thread overview]
Message-ID: <tencent_4DA07B856AB3D527AF6828307764B419DC09@qq.com> (raw)
In-Reply-To: <9c227fe2-3344-4aba-8559-6ae456da355c@163.com>

Hi Baolin,

On 2026/11/12 14:49, liubaolin wrote:
>> +	folio_wait_locked(folio);
>> +	read_failed = !folio_test_uptodate(folio);
>> +	folio_put(folio);
>> +	goto repeat;
>
> Could we keep the reference here and recheck uptodate under the
> folio lock? We're dropping it even when the read succeeded, so reclaim
> could remove the folio before the next lookup and we'd have to read it
> again. We'd still need to check the mapping after taking the lock.

Good point, thanks. I'll do that in v3.

Thanks,
xkeyC


      reply	other threads:[~2026-11-12  7:05 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-12  3:29 xkeyC
2026-11-12  6:49 ` liubaolin
2026-11-12  7:05   ` xkeyC [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tencent_4DA07B856AB3D527AF6828307764B419DC09@qq.com \
    --to=xkeyc@qq.com \
    --cc=hyc.lee@gmail.com \
    --cc=linkinjeon@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=liubaolin12138@163.com \
    --cc=ntfs@lists.linux.dev \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®