From: 王洪辉 <honghui.wang@ucas.com.cn>
To: "Sudeep Holla" <sudeep.holla@arm.com>
Cc: "Cristian Maruss" <cristian.marussi@arm.com>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V2 3/3] arm_scpi: Rev last modify to support acpi
Date: Thu, 24 Nov 2022 20:26:24 +0800 [thread overview]
Message-ID: <tencent_52A351CD61E76A06527CACF5@qq.com> (raw)
In-Reply-To: <20221124111450.mqfpmatba6f7pap6@bogus>
Ok!
Thanks,
Best Regards!
Wang Honghui
------------------ Original ------------------From: "Sudeep Holla"<sudeep.holla@arm.com>;Date: Thu, Nov 24, 2022 07:15 PMTo: "Wang Honghui"<honghui.wang@ucas.com.cn>; Cc: "Cristian Maruss"<cristian.marussi@arm.com>; "linux-arm-kernel"<linux-arm-kernel@lists.infradead.org>; "linux-kernel"<linux-kernel@vger.kernel.org>; Subject: Re: [PATCH V2 3/3] arm_scpi: Rev last modify to support acpi On Thu, Nov 24, 2022 at 05:59:47PM +0800, Wang Honghui wrote:> Rev last modify to support acpi> > Signed-off-by: Wang Honghui <honghui.wang@ucas.com.cn>> ---> drivers/firmware/arm_scpi.c | 4 ++++> 1 file changed, 4 insertions(+)> > diff --git a/drivers/firmware/arm_scpi.c b/drivers/firmware/arm_scpi.c> index e2e90dcc38bd..aca0a9780c12 100644> --- a/drivers/firmware/arm_scpi.c> +++ b/drivers/firmware/arm_scpi.c> @@ -908,7 +908,9 @@ static const struct of_device_id shmem_of_match[] __maybe_unused = {> { }> };> > +#ifdef CONFIG_PHYTIUM_MBOX> extern struct mbox_chan *phytium_mbox_request_channel(struct mbox_client *cl);> +#endifI have already NACK the approach you have taken for SCPI + ACPI. Just forgotto mention SCPI is old and deprecated protocol and SCMI replaced it. Youmuch be using that if possible.Anyways, this kind of #ifdeffery is not allowed in any generic code even ifI agreed with the approach. So please don't change the code in such a way.-- Regards,Sudeep
prev parent reply other threads:[~2022-11-24 12:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-24 9:59 Wang Honghui
2022-11-24 11:14 ` Sudeep Holla
2022-11-24 12:26 ` 王洪辉 [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tencent_52A351CD61E76A06527CACF5@qq.com \
--to=honghui.wang@ucas.com.cn \
--cc=cristian.marussi@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sudeep.holla@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®