From: Junjie Fu <fujunjie1@qq.com>
To: Arnd Bergmann <arnd@kernel.org>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, SeongJae Park <sj@kernel.org>
Subject: Re: [PATCH] mm: include linux/pagemap.h where needed
Date: Fri, 13 Dec 2024 02:03:23 +0800 [thread overview]
Message-ID: <tencent_59A379EC8F58DD64596C72493C232856CF0A@qq.com> (raw)
In-Reply-To: <20241212153916.1292365-1-arnd@kernel.org>
On December 12, 2024 at 23:39, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The pagemap header used to be included by accident here but is now
> missing:
>
> mm/z3fold.c: In function 'free_z3fold_page':
> mm/z3fold.c:353:17: error: implicit declaration of function 'lock_page'; did you mean 'copy_page'? [-Wimplicit-function-declaration]
> 353 | lock_page(page);
> | ^~~~~~~~~
> | copy_page
>
> Add the correct #include statement.
>
> Fixes: a6c37165ca40 ("mempolicy.h: remove unnecessary header file inclusions with no test failure")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> mm/z3fold.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/mm/z3fold.c b/mm/z3fold.c
> index 379d24b4fef9..4ae93bb2e3ab 100644
> --- a/mm/z3fold.c
> +++ b/mm/z3fold.c
> @@ -30,6 +30,7 @@
> #include <linux/mm.h>
> #include <linux/module.h>
> #include <linux/page-flags.h>
> +#include <linux/pagemap.h>
> #include <linux/migrate.h>
> #include <linux/node.h>
> #include <linux/compaction.h>
Thank you for your fix!
prev parent reply other threads:[~2024-12-12 18:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-12 15:39 Arnd Bergmann
2024-12-12 18:03 ` Junjie Fu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tencent_59A379EC8F58DD64596C72493C232856CF0A@qq.com \
--to=fujunjie1@qq.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=sj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®