From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out203-205-221-149.mail.qq.com (out203-205-221-149.mail.qq.com [203.205.221.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 65F423BB687 for ; Mon, 17 Aug 2026 14:08:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=203.205.221.149 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786975698; cv=none; b=DvUmPqSrCx/m7i0PkIVy0IFhx552VsN0Mo5VgYWk1+FVTm7WATFWLeU/KIROrQ5GpmzjImIazWbz3+2qmE3PJ6o5+akpkznPXXBlfThhkgDWxpuysMk/YYYcEjl6qBuepbOUm8MEp+3V29iy8sbC9HuFnpvkYb9E3txhMd0vTRM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786975698; c=relaxed/simple; bh=A2Wj/zxhiBtRiGXaAnMsRGO5cNQzfApTNPnrefJ+wHA=; h=Message-ID:From:To:Cc:Subject:Date:In-Reply-To:References: MIME-Version; b=KzNsBEbkGe/S9uHxVU6NS8aD8p7u/38naR1XIxEIK29ee2cMSPJbgWK4XPh9YWy9Tudo+vSQag6qjpvo3obl+khbZL8OFIFW+8tIY44vQxoeyQ8REa8qyDVZYAuy3gugqg6ePkhZOZoFqwDM+QZke5CQ4HSB2nB5AO3OcuL+Ka8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=qq.com; spf=pass smtp.mailfrom=qq.com; dkim=pass (1024-bit key) header.d=qq.com header.i=@qq.com header.b=PV4JL7/z; arc=none smtp.client-ip=203.205.221.149 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=qq.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=qq.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=qq.com header.i=@qq.com header.b="PV4JL7/z" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qq.com; s=s201512; t=1786975687; bh=pYrB//fNhlBAr08hpbgFJJO/+507kkmkqTKaivGAAck=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=PV4JL7/zKoOV11XaDdAkYdkh7OUJZG8i1t9k+8/mhC9xdqR8WeADWTwyQURKc9kcK jOkB9pEG27yLh2pyJuBsOsM68CcH1NyjvDBZ2epdhEgtaotpQ4oBt+8REluIOZvIJa v/o3Fa3IEAc/EPsXq1iR88cUXHfJl3R+N/d9bXqQ= Received: from lxu-ped-host.. ([111.198.231.89]) by newxmesmtplogicsvrsza63-0.qq.com (NewEsmtp) with SMTP id 204936F3; Mon, 17 Aug 2026 22:08:04 +0800 X-QQ-mid: xmsmtpt1786975684tpxh9x3j1 Message-ID: X-QQ-XMAILINFO: N/WmRbclY25GTXsmtc7MSI8xGnW7zo7a7EHrbOcXfVUcouGIvhAj2VrG0O0Eph m33vucxQoFUMIqF9DaOZkY0UjzIq1JPvKpNaCEpAPsu/+Qvq5gNtNq5KiJH+LdPlbi1kYgqVhmH/ R7QCyx+FlJIKBk6SQyOTFyUu9fAXSfF91n4Lni4OCKGpj6B2ItC87YiDhhJ4X2rXDjPdyZup5vVO tIuf6Eiche5JSayTiAoQ+rom+CLexPA92KWqtMIlKzJrnheCfsPLiyL0Y4DNNxVF5JQLcdpcpm+p QLhuwY7KwMfOjYXdCglV3c4kj7D7zzc4Y7iMDvUgcwviWJNcPx8K6VhFgs5fsL8oW/lHLm1wmmsv my15tg4QHiSni8y92Y8DiRuHT24R5vv1thvtIu0Wre4a60f1wgC7KBJTgSv4kQDtG573TUS94v+5 GgilkqKZi7j0aUU96QN6J/12ODkOI4fByzCLLOi0bOeHlPsLEh/K4SBJ8msFn7/ej0nHPUN/O9Op 5tPR9lPmH4eZRvl5b+O0rIlgKAaK01vfs2BGcTrT892PUGa9ZOCZSYp3gM1ij8cdJs0JgvdGDA53 O9qSVyHSqrsE2QDlhPxBitMqeac1a3Ot+YF5H+q+OIubBJ3RLpgk1ghm0pdA7ZtRxH3G/Th8BZ1w yTMo+c31k1VWGBWVWA96h2ZUteBBcuwsoReDYsHZpwo7zshHHxgCZFSRp2hUg+taSgzdav1JyKWQ LnS1LxLy9I73x4yBQM9BkVQPa18l0LxWF6nznzTqOr60LvUKt4Ta0VfqShAPQyFVwK9Mx2hiUHxx CQjYhXrWPCO12gSWSVBEpnCPBeQVK0qslb/T/a3qnlN7hahfrZmV5yLfPppHU/p60bGbG8IxvP8n qIyCH7uKYanUn3eOreBEZ5o0pBuVJ7UynSqMcOD8tYvX5ZeVqgQY34lHdxzlUW4wt+DQoOehqyOF lyRxdZwPwfzUy4E4J8Xpcabsz+JLjU3pTuUpxuU4BzK6q2arCQI+Zsl+P0W8YiWHB2myqGP4swnF ZjVv+m7TsNqYjw8zOA X-QQ-XMRINFO: NI4Ajvh11aEjEMj13RCX7UuhPEoou2bs1g== From: Edward Adam Davis To: syzbot+1944765c3659f63d3777@syzkaller.appspotmail.com Cc: linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com Subject: Re: [syzbot] [dri?] general protection fault in drm_object_attach_property Date: Mon, 17 Aug 2026 22:08:05 +0800 X-OQ-MSGID: <20260817140804.370840-2-eadavis@qq.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <6a829a95.dbb3a75c.20434b.0043.GAE@google.com> References: <6a829a95.dbb3a75c.20434b.0043.GAE@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit #syz test diff --git a/drivers/gpu/drm/drm_connector.c b/drivers/gpu/drm/drm_connector.c index 11646453aaac..12f4c5fcec92 100644 --- a/drivers/gpu/drm/drm_connector.c +++ b/drivers/gpu/drm/drm_connector.c @@ -2175,8 +2175,12 @@ int drm_mode_create_tv_properties_legacy(struct drm_device *dev, struct drm_property *tv_subconnector; unsigned int i; - if (dev->mode_config.tv_select_subconnector_property) + if (dev->mode_config.tv_select_subconnector_property) { + if (num_modes && !dev->mode_config.legacy_tv_mode_property) + goto tv_mode; + return 0; + } /* * Basic connector properties @@ -2205,18 +2209,6 @@ int drm_mode_create_tv_properties_legacy(struct drm_device *dev, if (drm_mode_create_tv_margin_properties(dev)) goto nomem; - if (num_modes) { - dev->mode_config.legacy_tv_mode_property = - drm_property_create(dev, DRM_MODE_PROP_ENUM, - "mode", num_modes); - if (!dev->mode_config.legacy_tv_mode_property) - goto nomem; - - for (i = 0; i < num_modes; i++) - drm_property_add_enum(dev->mode_config.legacy_tv_mode_property, - i, modes[i]); - } - dev->mode_config.tv_brightness_property = drm_property_create_range(dev, 0, "brightness", 0, 100); if (!dev->mode_config.tv_brightness_property) @@ -2247,6 +2239,19 @@ int drm_mode_create_tv_properties_legacy(struct drm_device *dev, if (!dev->mode_config.tv_hue_property) goto nomem; +tv_mode: + if (num_modes) { + dev->mode_config.legacy_tv_mode_property = + drm_property_create(dev, DRM_MODE_PROP_ENUM, + "mode", num_modes); + if (!dev->mode_config.legacy_tv_mode_property) + goto nomem; + + for (i = 0; i < num_modes; i++) + drm_property_add_enum(dev->mode_config.legacy_tv_mode_property, + i, modes[i]); + } + return 0; nomem: return -ENOMEM;