Re: [RFC PATCH] vfat:avoid unnecessary check

[zhoumin <teczm@foxmail.com>]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=y, Size: 630 bytes --]

Hi Hirofumi

> Hm, IS_FREE() checks 0 and DELETED_FLAG, isn't it?

Yes, you're absolutely right. That was my mistake—sorry about that. Please
disregard that part.

> OK, thanks. I got the reason.

> However I would prefer to keep the current code, for readability and
> future changes, and explicitly check those time flags if there is no
> measurable improvement.

I understand your preference. That said, since fat_truncate_time already checks
the flags and handles them appropriately, I still feel the double-check might be
redundant. That said, I respect your decision and am okay with keeping it as is.


Thanks,

zhoumin