mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Edward Adam Davis <eadavis@qq.com>
To: syzbot+2373f6be3e6de4f92562@syzkaller.appspotmail.com
Cc: akpm@linux-foundation.org, axboe@kernel.dk, dvyukov@google.com,
	linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-trace-kernel@vger.kernel.org,
	mathieu.desnoyers@efficios.com, mhiramat@kernel.org,
	pengfei.xu@intel.com, rostedt@goodmis.org,
	syzkaller-bugs@googlegroups.com
Subject: [PATCH] trace/blktrace: fix task hung in blk_trace_remove
Date: Wed, 31 Jan 2024 21:28:04 +0800	[thread overview]
Message-ID: <tencent_6D33089EBD1B9C4BEE1B2425C6BAB4BB9F08@qq.com> (raw)
In-Reply-To: <0000000000002b1fc7060fca3adf@google.com>

Delete critical sections that are time-consuming and protected by other mutexes
to avoid this issue.

Reported-and-tested-by: syzbot+2373f6be3e6de4f92562@syzkaller.appspotmail.com
Signed-off-by: Edward Adam Davis <eadavis@qq.com>
---
 kernel/trace/blktrace.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/kernel/trace/blktrace.c b/kernel/trace/blktrace.c
index d5d94510afd3..4543be718362 100644
--- a/kernel/trace/blktrace.c
+++ b/kernel/trace/blktrace.c
@@ -313,6 +313,7 @@ static void __blk_add_trace(struct blk_trace *bt, sector_t sector, int bytes,
 
 static void blk_trace_free(struct request_queue *q, struct blk_trace *bt)
 {
+	mutex_unlock(&q->debugfs_mutex);
 	relay_close(bt->rchan);
 
 	/*
@@ -325,6 +326,7 @@ static void blk_trace_free(struct request_queue *q, struct blk_trace *bt)
 	} else {
 		debugfs_remove(bt->dir);
 	}
+	mutex_lock(&q->debugfs_mutex);
 	free_percpu(bt->sequence);
 	free_percpu(bt->msg_data);
 	kfree(bt);
-- 
2.43.0


  parent reply	other threads:[~2024-01-31 13:34 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-25 19:31 [syzbot] [block?] [trace?] INFO: task hung in blk_trace_remove (2) syzbot
2024-01-30  1:00 ` Edward Adam Davis
2024-01-30  1:48   ` syzbot
2024-01-30  2:15 ` Edward Adam Davis
2024-01-30  6:40   ` syzbot
2024-01-30  6:48 ` Edward Adam Davis
2024-01-30  7:55   ` syzbot
2024-01-30  8:37 ` Edward Adam Davis
2024-01-30  9:18   ` syzbot
2024-01-30  9:56 ` Edward Adam Davis
2024-01-30 10:21   ` syzbot
2024-01-30 10:53 ` Edward Adam Davis
2024-01-30 11:41   ` syzbot
2024-01-30 13:38 ` Edward Adam Davis
2024-01-30 16:03   ` syzbot
2024-01-31  1:04 ` Edward Adam Davis
2024-01-31  7:54   ` syzbot
2024-01-31  8:18 ` Edward Adam Davis
2024-01-31  9:18   ` syzbot
2024-01-31  9:32 ` Edward Adam Davis
2024-01-31 10:00   ` syzbot
2024-01-31  9:38 ` Edward Adam Davis
2024-01-31 10:17   ` syzbot
2024-01-31 10:13 ` Edward Adam Davis
2024-01-31 10:42   ` syzbot
2024-01-31 10:14 ` Edward Adam Davis
2024-01-31 11:07   ` syzbot
2024-01-31 11:53 ` Edward Adam Davis
2024-01-31 12:40   ` syzbot
2024-01-31 13:28 ` Edward Adam Davis [this message]
2024-01-31 14:54   ` [PATCH] trace/blktrace: fix task hung in blk_trace_remove Jens Axboe
2024-11-13 17:22 ` [syzbot] [block?] [trace?] INFO: task hung in blk_trace_remove (2) syzbot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tencent_6D33089EBD1B9C4BEE1B2425C6BAB4BB9F08@qq.com \
    --to=eadavis@qq.com \
    --cc=akpm@linux-foundation.org \
    --cc=axboe@kernel.dk \
    --cc=dvyukov@google.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-trace-kernel@vger.kernel.org \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=mhiramat@kernel.org \
    --cc=pengfei.xu@intel.com \
    --cc=rostedt@goodmis.org \
    --cc=syzbot+2373f6be3e6de4f92562@syzkaller.appspotmail.com \
    --cc=syzkaller-bugs@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®