From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out203-205-221-202.mail.qq.com (out203-205-221-202.mail.qq.com [203.205.221.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C8DB62222D0 for ; Tue, 18 Nov 2025 03:40:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=203.205.221.202 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763437236; cv=none; b=V5ftG2Vapca8JyE3k71YvVzLuQd0mvoiaMYXMFGT7ifLhmI28HVeRGTcO+qN8pvC8HEfj5CVhVSUdc/bWsk+ZAx32VlUdfl28OZTpsQeApCKrHuwzRuQX6V/IkkAfsvazcQyyMKPhYFXt1fhd6Kg622YHqYpwUc7ycXNuYEyAUk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763437236; c=relaxed/simple; bh=3nxzBPUOo/hwQXG8QmO+w+mWT+938ZFdj6ha3o4lCO0=; h=Message-ID:From:To:Cc:Subject:Date:In-Reply-To:References: MIME-Version; b=S8oTCoX4MlLrXLOoNNeG2oijY48+RDlleRENzyAGmRfDDFrbT9LdzC7vImbEATwTe2JM29EjnT3wFcZT3oLT+THgMr6/J01iu0coY/d0a2srFWHQIBKlb66YlcjbBhOqNZHrrSYDxQ60ICUTghOBr1oiIxXwM9Vbl2DmvJGhkXw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=qq.com; spf=pass smtp.mailfrom=qq.com; dkim=pass (1024-bit key) header.d=qq.com header.i=@qq.com header.b=XCHm3NTc; arc=none smtp.client-ip=203.205.221.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=qq.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=qq.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=qq.com header.i=@qq.com header.b="XCHm3NTc" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qq.com; s=s201512; t=1763437225; bh=Cg03UWApqSdp1xuR/wsI+2lEqESR+ffq1/OJKAlKcz4=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=XCHm3NTciM75icCI1/KddhGzmaT/WLnlWc+9BL0heCBe9UWWjNJk7RXLVLGDZbXdE ioP5H0B4Ybbio9WK0f8WDTdAQvVngHjxDiE/g9NGGbFylYv/Yk5y6BuBGdwiSEsm8u 9orgMgaWxHkb13a0fKKFJDN19sgmPhhkFilgAOis= Received: from lxu-ped-host.. ([111.201.7.117]) by newxmesmtplogicsvrszb42-0.qq.com (NewEsmtp) with SMTP id A17B8271; Tue, 18 Nov 2025 11:40:23 +0800 X-QQ-mid: xmsmtpt1763437223tq8hne164 Message-ID: X-QQ-XMAILINFO: MRMtjO3A6C9X+1m100Xriie4L+Jyb2Tkc3A5eESVlNJvn49dfHGr4C6KouuoF7 zCM59pOiKy5AwpTbY3T5+uYIBI2tCNnQiOdXEdEN45YOaTez/kzqYAPCx8VXopcxqj1N8WAzdmvs +9A1OsYUqwy/4YbkEIIWNt/NyXqtXdnXLG1Tp8DxxyAlOqf65yrZHvg2dTluUkZ5dxWaq2tmcflB jA2DjfJQZ2FpWHlutRE6TP+MPL/q1CY+uSVfpA/QtrRqabTBkOMoYRwxZST9BIYVeHgj4sZazdZu EO+DOoXU5u6vWvVFnKwK2Hf6j6a/Uht3QN/VdWj5kHUTMKZfouZjRn9HVmCUxRiC4dgHugc6FQOv koMan6RCyS8PFItEdwOuNYJ3x2floHfFgfXmup7YGtFJ0NkKJYHjUVgtSH0JkONIXpfw5fZbPTcL IDRTYYQYFNuhpYMt8auLtfdFT0h0eUdlcGMM+XHFyyhBhuxDEnE1cMg1lC2VvO0a+CzBNTIhjpjc W08/8NtlbvNviJH7Tf81aH31BqEwbZTcNQ9OmNJtGwGo+JEFvCZNwx4CVCFT27w/S1zrmzfMLamu JBZ+OyQH4sjXkCaRPtXn93Km4J6WLXVLXhafPkOcpWN1djAasS5iXizrJvhmhUSZkRViIMuUC9gc BPI6gISE46zQxiyzQMAO+uAUfp00NrqNtdJRUd8tfMAG6ls5kbBZwkYtvSxycuYVBSDjK/Hlk6/c ZRNamwWWRuOYEg5116e8MBcK9DD2qn7gYE8bxu1ADo+gmghpdEuNY1GON+MhU1G+rmNSX3+JXCYC 1ymJNy2qDAd9zwOUP32b3qYNF+LDkKX5Yq9kCcbHvNHvkkl6M3VxjtBTMjMDvNxY25fehPZAztXH rsNrpueNX7tvqArveTFEa86RCRPLvEYw3/Rtx88cWB5Q1Yndp0B69mH6Nys8Id6DhS4e/Mi372jV PhMK///ki1ANJahpIsOxNoQUCT32nWfLSKqUXRPGRDqrSokMdtBghI/awUJvlJ X-QQ-XMRINFO: NI4Ajvh11aEj8Xl/2s1/T8w= From: Edward Adam Davis To: syzbot+f098d64cc684b8dbaf65@syzkaller.appspotmail.com Cc: linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com Subject: Re: [syzbot] [bluetooth?] [usb?] memory leak in __hci_cmd_sync_sk Date: Tue, 18 Nov 2025 11:40:23 +0800 X-OQ-MSGID: <20251118034022.4104477-2-eadavis@qq.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <691b301e.a70a0220.f6df1.0011.GAE@google.com> References: <691b301e.a70a0220.f6df1.0011.GAE@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit #syz test diff --git a/net/bluetooth/hci_sync.c b/net/bluetooth/hci_sync.c index 6e76798ec786..81fb553ceb56 100644 --- a/net/bluetooth/hci_sync.c +++ b/net/bluetooth/hci_sync.c @@ -201,7 +201,7 @@ struct sk_buff *__hci_cmd_sync_sk(struct hci_dev *hdev, u16 opcode, u32 plen, bt_dev_dbg(hdev, "end: err %d", err); - if (err < 0) { + if (err <= 0) { kfree_skb(skb); return ERR_PTR(err); }