From: Edward Adam Davis <eadavis@qq.com>
To: syzbot+cfc08744435c4cf94a40@syzkaller.appspotmail.com
Cc: linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com
Subject: Re: [syzbot] [kernel?] KMSAN: kernel-infoleak-after-free in copy_siginfo_to_user (2)
Date: Sun, 31 Dec 2023 09:51:27 +0800 [thread overview]
Message-ID: <tencent_72978236184B82740F7673674C3CC3360409@qq.com> (raw)
In-Reply-To: <000000000000a9d761060d5ce6cf@google.com>
please test kernel-infoleak-after-free in copy_siginfo_to_user
#syz test https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 861deac3b092
diff --git a/kernel/ptrace.c b/kernel/ptrace.c
index d8b5e13a2229..8bd346b10c6e 100644
--- a/kernel/ptrace.c
+++ b/kernel/ptrace.c
@@ -1033,7 +1033,7 @@ int ptrace_request(struct task_struct *child, long request,
{
bool seized = child->ptrace & PT_SEIZED;
int ret = -EIO;
- kernel_siginfo_t siginfo, *si;
+ kernel_siginfo_t siginfo, *si, *psiginfo;
void __user *datavp = (void __user *) data;
unsigned long __user *datalp = datavp;
unsigned long flags;
@@ -1061,9 +1061,13 @@ int ptrace_request(struct task_struct *child, long request,
break;
case PTRACE_GETSIGINFO:
- ret = ptrace_getsiginfo(child, &siginfo);
+ psiginfo = kvmalloc(sizeof(kernel_siginfo_t), GFP_KERNEL);
+ if (!psiginfo)
+ break;
+ ret = ptrace_getsiginfo(child, psiginfo);
if (!ret)
- ret = copy_siginfo_to_user(datavp, &siginfo);
+ ret = copy_siginfo_to_user(datavp, psiginfo);
+ kvfree(psiginfo);
break;
case PTRACE_SETSIGINFO:
next prev parent reply other threads:[~2023-12-31 2:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-21 18:49 syzbot
2023-12-25 22:15 ` syzbot
2023-12-31 1:51 ` Edward Adam Davis [this message]
2023-12-31 2:15 ` syzbot
2023-12-31 2:41 ` [PATCH] ptrace: fix kernel-infoleak-after-free in copy_siginfo_to_user Edward Adam Davis
2024-03-24 9:13 ` [syzbot] [kernel?] KMSAN: kernel-infoleak-after-free in copy_siginfo_to_user (2) syzbot
2023-12-25 7:16 xingwei lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tencent_72978236184B82740F7673674C3CC3360409@qq.com \
--to=eadavis@qq.com \
--cc=linux-kernel@vger.kernel.org \
--cc=syzbot+cfc08744435c4cf94a40@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®