From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S967027AbdIZBs3 (ORCPT ); Mon, 25 Sep 2017 21:48:29 -0400 Received: from smtpbgbr2.qq.com ([54.207.22.56]:42327 "EHLO smtpbgbr2.qq.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965654AbdIZBs2 (ORCPT ); Mon, 25 Sep 2017 21:48:28 -0400 X-QQ-GoodBg: 0 X-QQ-SSF: 00100000000000F0 X-QQ-FEAT: zEy9C1EMlXy7WPI/SQ58kts/3FIhfCS5QsutfQtW0fKtin7TOvWVtrhgEPC6l /OgPP5e/5Iu/SBRQoChax+W2+rr4PVioYgNXwomtYov1PSQH8+/B1Rp030I3MurQx2XtuRw HWVq6Ka8mieFEmGt0/zP9Jbcftzg5c9pZe5ioujPGNHgMzIx9uzwLUqVHpgQvlUvQy9TJoZ tgM0fKPkbJH8YXwNX4/seToJNpZIJCXm7VO8sweL6DRKcZBgSHy+SNymtED1g5OHMJY8W4q e+GZN9EhW4g8NmujE+Lq+RMAMoFbao1rFPGg== X-QQ-BUSINESS-ORIGIN: 2 X-Originating-IP: 222.92.124.153 X-QQ-STYLE: X-QQ-mid: bizmailfree34t1506390482t2089 From: "=?utf-8?B?6ZmI5Y2O5omN?=" To: "=?utf-8?B?Q2hyaXN0b3BoIEhlbGx3aWc=?=" Cc: "=?utf-8?B?Q2hyaXN0b3BoIEhlbGx3aWc=?=" , "=?utf-8?B?TWFyZWsgU3p5cHJvd3NraQ==?=" , "=?utf-8?B?Um9iaW4gTXVycGh5?=" , "=?utf-8?B?QW5kcmV3IE1vcnRvbg==?=" , "=?utf-8?B?RnV4aW4gWmhhbmc=?=" , "=?utf-8?B?bGludXgta2VybmVs?=" , "=?utf-8?B?UmFsZiBCYWVjaGxl?=" , "=?utf-8?B?SmFtZXMgSG9nYW4=?=" , "=?utf-8?B?bGludXgtbWlwcw==?=" , "=?utf-8?B?SmFtZXMgRSAuIEogLiBCb3R0b21sZXk=?=" , "=?utf-8?B?TWFydGluIEsgLiBQZXRlcnNlbg==?=" , "=?utf-8?B?bGludXgtc2NzaQ==?=" , "=?utf-8?B?Um9sYW5kIERyZWllcg==?=" , "=?utf-8?B?UGF3ZWwgT3NjaWFr?=" , "=?utf-8?B?S3l1bmdtaW4gUGFyaw==?=" , "=?utf-8?B?TWljaGFlbCBDaGFu?=" , "=?utf-8?B?QmVuamFtaW4gSGVycmVuc2NobWlkdA==?=" , "=?utf-8?B?SXZhbiBNaWtoYXlsb3Y=?=" , "=?utf-8?B?VGFyaXEgVG91a2Fu?=" , "=?utf-8?B?QW5keSBHcm9zcw==?=" , "=?utf-8?B?TWFyayBBIC4gR3JlZXI=?=" , "=?utf-8?B?Um9iZXJ0IEJhbGR5Z2E=?=" , "=?utf-8?B?c3RhYmxl?=" Subject: Re: [PATCH V7 1/2] dma-mapping: Rework dma_get_cache_alignment() Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Date: Tue, 26 Sep 2017 09:48:01 +0800 X-Priority: 3 Message-ID: X-QQ-MIME: TCMime 1.0 by Tencent X-Mailer: QQMail 2.x X-QQ-Mailer: QQMail 2.x References: <1506332766-23966-1-git-send-email-chenhc@lemote.com> <20170925125107.GC8130@lst.de> In-Reply-To: <20170925125107.GC8130@lst.de> X-QQ-ReplyHash: 1587890027 X-QQ-SENDSIZE: 520 Feedback-ID: bizmailfree:lemote.com:qybgforeign:qybgforeign4 X-QQ-Bgrelay: 1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id v8Q1n1aD029211 Hi, Christoph, Can I put the declaration in asm/dma-coherence.h? And, last time you said it is OK to pass a NULL to dma_get_cache_alignment() and cc all driver maintainers. I have do so. Huacai ------------------ Original ------------------ From: "Christoph Hellwig"; Date: Mon, Sep 25, 2017 08:51 PM To: "Huacai Chen"; Cc: "Christoph Hellwig"; "Marek Szyprowski"; "Robin Murphy"; "Andrew Morton"; "Fuxin Zhang"; "linux-kernel"; "Ralf Baechle"; "James Hogan"; "linux-mips"; "James E . J . Bottomley"; "Martin K . Petersen"; "linux-scsi"; "Roland Dreier"; "Pawel Osciak"; "Kyungmin Park"; "Michael Chan"; "Benjamin Herrenschmidt"; "Ivan Mikhaylov"; "Tariq Toukan"; "Andy Gross"; "Mark A . Greer"; "Robert Baldyga"; "stable"; Subject: Re: [PATCH V7 1/2] dma-mapping: Rework dma_get_cache_alignment() > index aba7138..e2c5d9e 100644 > --- a/arch/mips/include/asm/dma-mapping.h > +++ b/arch/mips/include/asm/dma-mapping.h > @@ -39,4 +39,6 @@ static inline void arch_setup_dma_ops(struct device *dev, u64 dma_base, > #endif > } > > +int mips_get_cache_alignment(struct device *dev); All the other mips generic dma helpers are prefixed mips_dma_* so it might make sense to follow that. Also please don't add arch-local helpers to asm/dma-mapping.h - this is a header used by linux/dma-mapping.h and should not contain implementation details if avoidable. > + dma_get_cache_alignment(NULL)) / mdev->limits.mtt_seg_size; As said before - please don't pass NULL to this function but the proper device, which would be &mdev->pdev->dev in this case for example.