From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out162-62-57-87.mail.qq.com (out162-62-57-87.mail.qq.com [162.62.57.87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0530343785E for ; Tue, 11 Aug 2026 13:38:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=162.62.57.87 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786455525; cv=none; b=eOglCj9bVG35OmTa5bxidh7mBx/DrzUaM8txD7v743HbesVx+65yThAHpIORfb4lHh8uH6eJYgmGbFpKelQ8zhWhZvpABN8xEKXojV6/jG+LcK2GiyofAHlPq6IdfyXsv0mVo6gzgmkNAcY7amlnHTJRgWKe72i8ekVWC+3qZG8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786455525; c=relaxed/simple; bh=7jAtsm0QKD9CGg1P6xDXHWpFYZJyBNOAZbInnUCDAb0=; h=Message-ID:Date:Subject:From:To:Cc:MIME-Version:Content-Type; b=FrL9VsvZTh8hohr0IBIAznGy8WdU3Nc2Pc1+plVuzEppyU/1VvW8eM0hPz+i6IVe/N4SfrgBUcc8PpfJ8opCfGJzoccmUil/XP6Ux+KFoBVop2R3Iuis1JAH1IYhHSCxMK14NybqCzdMbTXiLuflAU/+em40lE8JKQx71WrUfh0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vip.qq.com; spf=pass smtp.mailfrom=vip.qq.com; dkim=pass (1024-bit key) header.d=vip.qq.com header.i=@vip.qq.com header.b=GpF6PKfr; arc=none smtp.client-ip=162.62.57.87 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vip.qq.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=vip.qq.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=vip.qq.com header.i=@vip.qq.com header.b="GpF6PKfr" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vip.qq.com; s=s201512; t=1786455502; bh=llA6SdfZeZT+ESXZVbMzl6QSydk1juvT9SBz5fS9omA=; h=Date:Subject:From:To:Cc; b=GpF6PKfrrrCvv5Af+xbwAH3XsyL8mOi7+5LdiMF52U9r/TyucuBpY4ygVnLzFqNJ9 8llpc56nuY24BZwk4K1NxZVEfcQkQm1GJjk8XGTVroGtgp5biVrAUTWMe2p+sIUMzx rqfmY+1QYWpk/HtAgZGvTeNZLdDOzjvKrgBZmygU= Received: from vip.qq.com ([111.52.124.140]) by newxmesmtplogicsvrsza73-0.qq.com (NewEsmtp) with SMTP id 99315824; Tue, 11 Aug 2026 21:38:19 +0800 X-QQ-mid: xmsmtpt1786455500tqfxdym5e Message-ID: X-QQ-XMAILINFO: MXzpxT/vcbSgGuU+SMipLPKjxX36Ejxf8FumwAJza8xdEXw3dlXmsaW/e2mmP/ 6Hythjj60IdxaB9Yf5+WPEhRqHiYX2NE+1zxVqDKCva7c/H6jJOhmh6E0artqLLRCmE5iME6W0vq k3TXGz3c0yZmgP7WrIkczRAXG/meHK+KJuR6AZ3eENECdaX+QtjJVOT1X52+/kb9brTv4GTcBl5G CbPVVKE2xXgpx8501CtKwKTWOTRnM4/CmHNn5yOSSnRZvwnQfIA31oKVdd8A+EdruwW6O1HzyXQA ymhs6wt1OBzeHPodZwg+tDNbALWkM8rN1Y8l7MPFfrYsBzQOYrr5ixd6dGdw0PRiDW5SP+3v3XuN LfEvTPjU4Ki+FA7bjYv6Zn52YTDOP2H+dlxySNeQC+elZVxV1AtIi09JB/Se3ZjcfR9F5JRlNLUY yj6VBqu7H5/Q6pn1fSgsYbmFbD1bRsW/A1Ec67vnd1CIU1mmgZxp9QK2+feh/CDHug03OJCxxJ6t qLwaKuO08iEbPiIDbq8WMypqMJrLH/nt8HIprI3zG+68AH3Rku9+rouWZCCaLNQ/komsGJkPTETq CycpJan9jveUJbPIupDxSFpeMUB69LRYG+GHD1oAG1LBSkI70swbOVpvz9PZCaTpZCAtdtixENrZ qT3C1ofTjzRdIhcvRQm/rX+JjOsvA9aQCvvjptDb/gN12lcPQzYg5/1wLP7d1YiX4hDPlzvIJCp5 npYQqF4XSFeS9SAPQs9GFncyeJLPfEqL3Ll76pvN6BmMeow85/gDd/iM+kjtGe/usp0eSwU9wAL+ 4IJSZQOj2cT4ONZ1g7vfHddBhEh0KQWD+ARwJy68cNW6Xr4EenR2Tn4HabCuYHrQNmOcuRo/MpHN 0g7Z95KsNriGXkzjlPfbqLIaGzppaFoK+bRgtO/NXja1ht/rinOPU+mDG1xSqbGb0vsbqsX4C75x A9MlqWVkjypzl3RNL97dKShHwerOT2YOpxazksfxPiC+wLnF0IzMQLW3fQPar0qMryiF9BMyBlAY iwZdsfD/2h2xKGh1vz6q1ApFoi5UYeVobHISzGG91ZCiZZbWtOVgldJokM9QGmEE/aBBKUEuUbst d8tXBF7hB25ODI4opjqCCwZsL8FIYEn3nyUBsJJxDHFcyka4pyu/EviPyEJY/CkJu27NP+uIVo8f tWivimQdNZcmzE3EqyVt99gDuEjHIlu7BHVsY= X-QQ-XMRINFO: NI4Ajvh11aEjEMj13RCX7UuhPEoou2bs1g== Date: Tue, 11 Aug 2026 20:55:50 +0800 Subject: [PATCH 2/2] nvmem: layouts: onie-tlv: fix device_node reference leak in error path From: Leo Cheng To: Srinivas Kandagatla , Michael Walle , Miquel Raynal Cc: linux-kernel@vger.kernel.org Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit onie_tlv_add_cells() takes a reference on the child node via of_get_child_by_name() for each parsed TLV and passes it to nvmem_add_one_cell() as cell.np. On success the created cell entry adopts that reference and releases it later via of_node_put(); on failure nvmem_add_one_cell() does not consume it, so the caller still owns it, but the error path only puts layout before returning, leaking the child node reference. Put cell.np on the error path as well. of_node_put(NULL) is a no-op, so this is safe even when of_get_child_by_name() returned NULL. Fixes: d3c0d12f6474 ("nvmem: layouts: onie-tlv: Add new layout driver") Signed-off-by: Leo Cheng --- drivers/nvmem/layouts/onie-tlv.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/nvmem/layouts/onie-tlv.c b/drivers/nvmem/layouts/onie-tlv.c index 8b0f3c1b8..4da3a7043 100644 --- a/drivers/nvmem/layouts/onie-tlv.c +++ b/drivers/nvmem/layouts/onie-tlv.c @@ -128,6 +128,7 @@ static int onie_tlv_add_cells(struct device *dev, struct nvmem_device *nvmem, ret = nvmem_add_one_cell(nvmem, &cell); if (ret) { + of_node_put(cell.np); of_node_put(layout); return ret; } -- 2.43.0