mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: LiuJunyuan <2058432396@qq.com>
To: nkapron@google.com
Cc: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	syzbot+2a7ce560c30c4ca3bc22@syzkaller.appspotmail.com,
	LiuJunyuan <2058432396@qq.com>
Subject: [PATCH] usb: gadget: udc: handle NULL request in tracepoint
Date: Wed, 11 Nov 2026 12:50:01 +0800	[thread overview]
Message-ID: <tencent_924108DBAEA30F3DD09C66FEC41A965A970A@qq.com> (raw)

usb_ep_alloc_request() passes a NULL request to
trace_usb_ep_alloc_request() when ep->ops->alloc_request() fails.
The udc_log_req tracepoint assumes req is non-NULL and dereferences
req->length, causing a NULL pointer dereference.

Make the tracepoint handle req == NULL so allocation failures can still
be recorded safely.

Reported-by: syzbot+2a7ce560c30c4ca3bc22@syzkaller.appspotmail.com
Closes: https://syzkaller.appspot.com/bug?extid=2a7ce560c30c4ca3bc22
Fixes: 5e42d710a108 ("usb: gadget: add tracepoints to the gadget API")
Signed-off-by: LiuJunyuan <2058432396@qq.com>
---
 drivers/usb/gadget/udc/trace.h | 30 +++++++++++++++++++++---------
 1 file changed, 21 insertions(+), 9 deletions(-)

diff --git a/drivers/usb/gadget/udc/trace.h b/drivers/usb/gadget/udc/trace.h
index fa3e6ddf0a12..bcf89b5693db 100644
--- a/drivers/usb/gadget/udc/trace.h
+++ b/drivers/usb/gadget/udc/trace.h
@@ -239,15 +239,27 @@ DECLARE_EVENT_CLASS(udc_log_req,
 	),
 	TP_fast_assign(
 		__assign_str(name);
-		__entry->length = req->length;
-		__entry->actual = req->actual;
-		__entry->num_sgs = req->num_sgs;
-		__entry->num_mapped_sgs = req->num_mapped_sgs;
-		__entry->stream_id = req->stream_id;
-		__entry->no_interrupt = req->no_interrupt;
-		__entry->zero = req->zero;
-		__entry->short_not_ok = req->short_not_ok;
-		__entry->status = req->status;
+		if (req) {
+			__entry->length = req->length;
+			__entry->actual = req->actual;
+			__entry->num_sgs = req->num_sgs;
+			__entry->num_mapped_sgs = req->num_mapped_sgs;
+			__entry->stream_id = req->stream_id;
+			__entry->no_interrupt = req->no_interrupt;
+			__entry->zero = req->zero;
+			__entry->short_not_ok = req->short_not_ok;
+			__entry->status = req->status;
+		} else {
+			__entry->length = 0;
+			__entry->actual = 0;
+			__entry->num_sgs = 0;
+			__entry->num_mapped_sgs = 0;
+			__entry->stream_id = 0;
+			__entry->no_interrupt = 0;
+			__entry->zero = 0;
+			__entry->short_not_ok = 0;
+			__entry->status = 0;
+		}
 		__entry->ret = ret;
 		__entry->req = req;
 	),
-- 
2.43.0


             reply	other threads:[~2026-11-11  4:51 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-11  4:50 LiuJunyuan [this message]
2026-11-11  6:28 Liu Junyuan
2026-11-20 14:39 ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tencent_924108DBAEA30F3DD09C66FEC41A965A970A@qq.com \
    --to=2058432396@qq.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=nkapron@google.com \
    --cc=syzbot+2a7ce560c30c4ca3bc22@syzkaller.appspotmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®