From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out203-205-221-191.mail.qq.com (out203-205-221-191.mail.qq.com [203.205.221.191]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 74FDE3845B7 for ; Thu, 19 Mar 2026 12:20:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=203.205.221.191 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773922844; cv=none; b=mmUylMDMzTvpKaEI9azbNoGBDhdXoIRF+OYVhGZQRlua4EArH6PO3s9IBnL0Y+KZY1pd+WOpFcQSVctqf7dm/BY+WD3Qf3C1aBtLev50E7ZvT1LEa71fzURg7EZ6sZIirlOKDilTdulny0j08LPlg5J6BZAwB9aEtBGFp86dk+g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773922844; c=relaxed/simple; bh=iC/OumqN0M3So/0mC2URrlKSJiRNTked7iDJeg98sC0=; h=Message-ID:From:To:Cc:Subject:Date:In-Reply-To:References: MIME-Version; b=nQ0mX3w/DPxF1LQ1BbRuPH+vaSTqIk3ownF4wIyGo2AgXQUNC28xRei0LZ7Vd8TxKEj1c5i5+ieM/n65EqkLZnG+9R21zG2WiHyMvaIW/TsW4zlQC/zGNzh/5T16krCK7/gedZeeHB4TrOXA8sAWGeVw1jEUWMYhcALvhVK+PfI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=qq.com; spf=pass smtp.mailfrom=qq.com; dkim=pass (1024-bit key) header.d=qq.com header.i=@qq.com header.b=RFHt9Q5x; arc=none smtp.client-ip=203.205.221.191 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=qq.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=qq.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=qq.com header.i=@qq.com header.b="RFHt9Q5x" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qq.com; s=s201512; t=1773922833; bh=brkd5WNmVl/dxS3YbEedfkfZw7uD05i7CFA/xJgjEuc=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=RFHt9Q5x9iXUrLcDPVhbBNov4To6s+kLSX3qq3RzMbHSBdlqPV63GW9syz3dML6ud UmuypaOVpW9ngmvIIRLIjV0Bvrt0qov3QdoynFCVmHOTpi8W3aU/0Z988UAraRLFJ/ NKXCX0XBLChkmmAIZL23RTVndBO2GocsBGvW0/P4= Received: from lxu-ped-host.. ([111.198.231.89]) by newxmesmtplogicsvrszc43-0.qq.com (NewEsmtp) with SMTP id 51F10EB2; Thu, 19 Mar 2026 20:20:31 +0800 X-QQ-mid: xmsmtpt1773922831tiok419od Message-ID: X-QQ-XMAILINFO: OOO9dHjlsLs7T8FbUMD/BBe+yhiqPhfAmHsASciySDPj7egtgK8mwDKhHXECNb eDX+g4ybj05uJhKZLLGuX5PSZNf4R3vmmTIOlTBa41ghPpYzTD/dq3IntnE12pY2yUpZyjdRGrUM RYismFx3/UPOGKND4dUehI47rDoEEDVSqf1YYR5nPfq7Gy2GhlFN4Z8Gcr92VDrwlTgnyn5vr+93 2NZC9GQK6MO2ViYGWqIRoGnS7y6woKfqauKVrdWWzPfA0CkbSANBFKypcR1RkcjWSJWu77M74onh 4MK3rOHknIUEr3I17J3XV+ngpezXHAIxx312mxrRM3c0Uc3PX3xu6d2L0wEj2PKrUu5rw/rOpPN9 FGMbSXVerLFWIGiERO+n7Dfjou8SXzkL3Vty0CkmE3IbJ+vALTYIJutWKHHm5xqdQI9Zg9lX8tL/ RhAqKJL6Sue8QRodLGkqE/+doIJUvwHLeY8g6io51/iOBFyZVQ+yEnCuR2lT+d0zw7OA5FSU8U1l kuKpsV3KBBGGr2iF3mccAV/N8v3ZFACGUOeEGYGo22g1HCDGnjfu+Xsz1dlmt1Hq0yZeENq3QJzs 22KtpSPwXJU6GhClR62ZYQjmb/UdEPG6MqcIA+AGsTG1Dr/9ceQPSZ+rDYiHi+ltUvtVdCcaGMzE UzLVY6toDDMvV5OJ9DuABKfGgpQfIfdaCO177ydAo5KLlLet6ga5rCg6grQ7AWHwG0szE1LqOcZ7 kZlI+nfk3zGKyJAyGUd/MDzMmgZb+gnmWme/ghWv4HoBVSDJYhXhBnAmqmLvP4VowhCu64WMz/fU 3Loaw3Ob2NZXxjh/Zx2+kPQK+Vr9dC+H+FcsUlAZY37h6yU1YPz7jPVqVcKPzFMpmZr0BDxXdgG4 M4L1e5jxl3YpKJq8n1jvdl8RFYyV4WhZVtURSoGS9gUaHgw+5Lm7y6/5a6RRPCy5x2gjCnbT+xRW pJpuC81dGhxKZvUCWTJZPgbFKpnmwP3cvzCtw6roDAocXsM8y5RZN8l1e+2LEtlHxzYQCrg2Y= X-QQ-XMRINFO: MSVp+SPm3vtSI1QTLgDHQqIV1w2oNKDqfg== From: Edward Adam Davis To: syzbot+1a7507a194fff09e5c44@syzkaller.appspotmail.com Cc: linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com Subject: Re: [syzbot] [media?] [usb?] KASAN: slab-use-after-free Read in v4l2_open Date: Thu, 19 Mar 2026 20:20:31 +0800 X-OQ-MSGID: <20260319122031.281034-2-eadavis@qq.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <69bba3fe.050a0220.227207.0030.GAE@google.com> References: <69bba3fe.050a0220.227207.0030.GAE@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit #syz test diff --git a/drivers/media/v4l2-core/v4l2-dev.c b/drivers/media/v4l2-core/v4l2-dev.c index 6ce623a1245a..cf9279a2d990 100644 --- a/drivers/media/v4l2-core/v4l2-dev.c +++ b/drivers/media/v4l2-core/v4l2-dev.c @@ -423,14 +423,18 @@ static int v4l2_open(struct inode *inode, struct file *filp) } /* and increase the device refcount */ video_get(vdev); - mutex_unlock(&videodev_lock); if (!video_is_registered(vdev)) { ret = -ENODEV; goto done; } + set_bit(V4L2_FL_BUSY, &vdev->flags); + mutex_unlock(&videodev_lock); + ret = vdev->fops->open(filp); + + mutex_lock(&videodev_lock); if (ret) goto done; @@ -448,6 +452,8 @@ static int v4l2_open(struct inode *inode, struct file *filp) /* decrease the refcount in case of an error */ if (ret) video_put(vdev); + clear_bit(V4L2_FL_BUSY, &vdev->flags); + mutex_unlock(&videodev_lock); return ret; } @@ -1121,6 +1127,11 @@ void video_unregister_device(struct video_device *vdev) return; mutex_lock(&videodev_lock); + while (test_bit(V4L2_FL_BUSY, &vdev->flags)) { + mutex_unlock(&videodev_lock); + cond_resched(); + mutex_lock(&videodev_lock); + } /* This must be in a critical section to prevent a race with v4l2_open. * Once this bit has been cleared video_get may never be called again. */ diff --git a/include/media/v4l2-dev.h b/include/media/v4l2-dev.h index 2e0f6d2e6a78..83feb0a4f4d3 100644 --- a/include/media/v4l2-dev.h +++ b/include/media/v4l2-dev.h @@ -95,6 +95,7 @@ enum v4l2_video_device_flags { V4L2_FL_USES_V4L2_FH = 1, V4L2_FL_QUIRK_INVERTED_CROP = 2, V4L2_FL_SUBDEV_RO_DEVNODE = 3, + V4L2_FL_BUSY = 4, }; /* Priority helper functions */