mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Congjie Zhou" <zcjie0802@qq.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: netdev <netdev@vger.kernel.org>,
	jasowangio <jasowangio@gmail.com>, eperezma <eperezma@redhat.com>,
	xuanzhuo <xuanzhuo@linux.alibaba.com>,
	andrew+netdev <andrew+netdev@lunn.ch>,
	davem <davem@davemloft.net>, edumazet <edumazet@kernel.org>,
	kuba <kuba@kernel.org>, pabeni <pabeni@redhat.com>,
	horms <horms@kernel.org>,
	virtualization <virtualization@lists.linux.dev>,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [BUG] virtio_net: RX stall caused by masking callbacks after NAPI ownership release
Date: Mon, 16 Nov 2026 16:47:17 +0800	[thread overview]
Message-ID: <tencent_94953697D2BA27275BEF7A26404E69800605@qq.com> (raw)
In-Reply-To: <20261115175445-mutt-send-email-mst@kernel.org>

Tried your patch with my earlier TCP test. No more complete NAPI
stalls so far, thanks!

But LLM found another possible interleaving, though. I reproduced it
in an instrumented KUnit test with injected delays, but haven't hit
it in the TCP test.

With defer_hard_irqs=1, it goes like this:

CPU1 / old poll                  CPU2 / busy-poll
-----------------------------    -----------------------------
Complete: clear SCHED,
arm timer, return false.
                                 Take NAPI ownership.
                                 Enter busy_poll_stop(), clear
                                 IN_BUSY_POLL. The final poll
                                 enables callbacks, then pauses
                                 before completion.
Watchdog expires, sees
SCHED=1, exits without
scheduling or setting MISSED.
Disable callbacks.
Timer=0, SCHED=1, so skip
napi_schedule() and exit.
                                 napi_complete_done(..., 0):
                                 defer count=0, no MISSED.
                                 Clear SCHED, return true.
                                 Queue is empty, exit.

Then the device adds a used entry, but callbacks are still disabled,
with no timer or poll pending.

So SCHED=1 at the check, but that poll has already enabled callbacks
and won't enable them again after the old poll masks them.


  reply	other threads:[~2026-11-16  8:47 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-11 13:36 Congjie Zhou
2026-11-11 13:50 ` [PATCH net 1/2] net: napi: add completion with an ordered IRQ mask callback Congjie Zhou
2026-11-11 13:56   ` netdev-bot+sinfo
2026-11-11 15:08     ` zcj
2026-11-11 13:50 ` [PATCH net 2/2] virtio_net: mask callbacks before releasing NAPI ownership Congjie Zhou
2026-11-15  7:12 ` [PATCH net v2 1/2] net: napi: add completion with an ordered IRQ mask callback Congjie Zhou
2026-11-15 18:26   ` Jakub Kicinski
2026-11-15  7:12 ` [PATCH net v2 2/2] virtio_net: mask callbacks before releasing NAPI ownership Congjie Zhou
2026-11-15 20:09 ` [BUG] virtio_net: RX stall caused by masking callbacks after NAPI ownership release Michael S. Tsirkin
2026-11-15 23:07 ` Michael S. Tsirkin
2026-11-16  8:47   ` Congjie Zhou [this message]
2026-11-16  9:52     ` Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tencent_94953697D2BA27275BEF7A26404E69800605@qq.com \
    --to=zcjie0802@qq.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@kernel.org \
    --cc=eperezma@redhat.com \
    --cc=horms@kernel.org \
    --cc=jasowangio@gmail.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=virtualization@lists.linux.dev \
    --cc=xuanzhuo@linux.alibaba.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®