From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from xmbghk7.mail.qq.com (xmbghk7.mail.qq.com [43.163.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0CF78224234 for ; Mon, 27 Apr 2026 16:21:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=43.163.128.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777306900; cv=none; b=k+ysgVUiXHKxS4JbSg89Nibs2ht2/BK9tci6wZL9z1L8QfJAEobC3SlM/cICrSLtIeWmIH4YbtqdugSEFRmU7xbiAyYFS639efweLt96G3vDuLbm/RiIq+z6cS90CJn4oaoMWBnqxAl6l8UKPr+CJIhtlVHb7cAxXte90bTObEU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777306900; c=relaxed/simple; bh=Qv5T2llCY7Jdq5wbaWSpQr20nZRTC/EVRfNcw1lmEc4=; h=Message-ID:From:To:Cc:Subject:Date:In-Reply-To:References: MIME-Version; b=NV+ExKGHRMhr+NMsr09AAYGM4GTCk/nMe2vCsoczx7gkGo6u+wQGKnnSUDjjw7jQA3fQNbbXQNisXM9wbsn2C/tRrqXyhzI7Z2GoZU0v49X4124iaQ2VD0cEmDI7Fw1v7dG3S2awY6RT/HP9tmpUUUrugmntzHWQvhIKq2ocAqc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=qq.com; spf=pass smtp.mailfrom=qq.com; dkim=pass (1024-bit key) header.d=qq.com header.i=@qq.com header.b=ItpP3WD3; arc=none smtp.client-ip=43.163.128.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=qq.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=qq.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=qq.com header.i=@qq.com header.b="ItpP3WD3" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qq.com; s=s201512; t=1777306893; bh=Qv5T2llCY7Jdq5wbaWSpQr20nZRTC/EVRfNcw1lmEc4=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=ItpP3WD3eJ3OQwiTc3HEFhYsIdC13pxcD6rXG2qHFIU0xAov1iiE419jzP8YS7yai QvLYHzNvQFgYB02qb0wMS6ZEi5cvwfuf4q4Qm66WAikQ3Hxd0V40Lyb3x29jRVnifq 3hjjLLy/H40GsVO9OQwPMDC5gkNKxC/j6p2uaTXs= Received: from node68.. ([166.111.236.25]) by newxmesmtplogicsvrszb43-0.qq.com (NewEsmtp) with SMTP id 55F09E02; Tue, 28 Apr 2026 00:21:31 +0800 X-QQ-mid: xmsmtpt1777306891t3b887e0q Message-ID: X-QQ-XMAILINFO: Nx5J06Esz7r7adk3nRgV4JYRK8JQCG1ZDJ9VLEbwqgY3ndga9r06rlFv2r3PkL hlZp/g3QIYCgpRe8vx/+zalxSiJY6ohoLEfteXbLfqysAy48E1pFmAuacGSkhQGDtq/OqpL2xVtL VpVoKhK1UMcuxpYL0gmv1mFTO2HbFvAfJVJgKU9uT+d2DE0zw5jrgBovFyivniJOOaqumV6QSbZG rJflasZ/Mq5PSxBjJafvJDOzdkuCRebR8LwOYI2kxE28zpY7NHtemgIeOrYw8P6Hl8E0GPx7s9ve tEahmOXN+7xVi5zaiSfSezSRSx/6wY+v2nZmPzry99NyyaT+oOznTJn6EdlrYtWHSEDoxKWX4TAh qvgDhJkn83vmGIklZlpF66MH96Oy6djDLvqFoe0OOzb2oCFC41HHGoqCUtAXlLMguWiZ7s/rcRdF Ffd77tsN/JoUK3QM+6DppJSYkdILZ69IbSC1XiBSFnN53nUURsbxmXRwx4mBR8M1KzCX3F5VSTgY H3CDENxL/3qUXSKcXevZtFBQRSm7ITbJ3WmD5rLJKhxQlvh9AE1IB+vC6Qw/TiI/1KkecRoYc3bD WuQFp1+fMLYdW10Yo2NP6C7x+FFF7Oez6H1KS/ESsuT9O5Pcwb5AaBoQA1NStFDEcWGsL2j+hqsJ 1iPW6GogVsV/roGdzttXIEcxXemdM8QGi7DeCpAkb9yErY6w1DN4t24rwbq1aJ/00iRJJmmTE7wl X+yIAzPP8jhoA5UarcpD5y3EKhiy82DzUNOQAeyvEq/pPX9rExN3z9sYnJ+vWmLfdcR5WcWsC7gy U1gIe4rKSXdFeg4+akDu1fxUxn/XYdYy1qNCX9AX2CGraelaLGY0A7pZc1QoNe9fHINrTIBd0D6s BeZWYksNp/WpMV4GBBhXUAWpxKIJo2bWEtolMiSM3sDNZ3TvoP+QHFE9wSilREgQIjPeT+Ob9XKZ w9g9sX7nelVacoTfwl3RToR955vX/v7uoqK8GtjMRUvVTLGS7UVWaN7Q1q0U5F X-QQ-XMRINFO: NI4Ajvh11aEjEMj13RCX7UuhPEoou2bs1g== From: fujunjie To: Jan Kara Cc: Matthew Wilcox , Andrew Morton , Roman Gushchin , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH 1/1] mm/filemap: tighten mmap_miss hit accounting Date: Mon, 27 Apr 2026 16:21:31 +0000 X-OQ-MSGID: <20260427162131.621461-1-fujunjie1@qq.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit On Mon, Apr 27, 2026 at 21:25, Jan Kara wrote: > 1) These are two separate logical changes - handling of filemap_map_pages() > and handling of FAULT_FLAG_TRIED. Please create two separate patches for > them. > > 2) After changing the mmap_miss logic in filemap_map_pages() there's no > need for the odd propagation of mmap_miss variable to > filemap_map_order0_folio() and filemap_map_folio_range(). Now you are > guaranteed to need to update mmap_miss at by at most 1. So I think you > should just drop mmap_miss argument, check return value of > filemap_map_order0_folio() / filemap_map_folio_range() in > filemap_map_pages() and based on it just update file->f_ra.mmap_miss if > appropriate. Much simpler. Thanks a lot for the review. Both points make sense to me. I'll send v2 shortly. Best regards, fujunjie