From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out203-205-221-153.mail.qq.com (out203-205-221-153.mail.qq.com [203.205.221.153]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0FC3A21CC59 for ; Fri, 17 Apr 2026 04:52:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=203.205.221.153 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776401537; cv=none; b=TJz0Egz/AVeshvHXFOBvsrmI2pYgcruOCm1oZ6NAmSrmKrdzECMnCEMKTJxxkcsR5nqgzc1oSlw/hOAK82TzxJLTmj1rUfcLF0buWfGaVhbzHwogZDtacP1+irvrz4UAg0829y7Q1pl8MPRj2AzJb1trf1jbjLxbaddJUNN+ZOQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776401537; c=relaxed/simple; bh=/97pC0mVDfym2tt5x34NJQSphBWXg87x2+uhgkB/hTY=; h=Message-ID:From:To:Cc:Subject:Date:In-Reply-To:References: MIME-Version; b=B5Ga/fXDEDC3kQu7hI6zFUID4UaPeW5+sGmmcr1TndO/g+xiIDoKF/57gRWi1XeVIY3urG0zHvd2k9iLzev5YXMQ1OQOqX84eSXhdUoPmPJfLEHH+HaVhPyZHsUgIzXhopBasgODc4wRxIt5ZrwsMp7UCjFGHwo/8x4+wjgrNOE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=qq.com; spf=pass smtp.mailfrom=qq.com; dkim=pass (1024-bit key) header.d=qq.com header.i=@qq.com header.b=txXsMcY7; arc=none smtp.client-ip=203.205.221.153 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=qq.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=qq.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=qq.com header.i=@qq.com header.b="txXsMcY7" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qq.com; s=s201512; t=1776401524; bh=My+zA15KbW/f/IIHaZTndY0PMMZhso4ONjg30XSPqzc=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=txXsMcY7UQBt/oiLv2TtixN9JTXOR2WVy1+IeVoL1Mk0Tc8aYdKlF74dcb1z6z62S s271bnku65pU7GsPRUHEoAK/mHGXgyzRQskh1Qk8nhye3MEuXzB4vBRkmrD4PAgt4T jM7vSRvJWr7xF0sPYhKwZdauDQqsnAJf1LKOElUw= Received: from lxu-ped-host.. ([111.198.231.89]) by newxmesmtplogicsvrsza73-0.qq.com (NewEsmtp) with SMTP id D02B1250; Fri, 17 Apr 2026 12:52:02 +0800 X-QQ-mid: xmsmtpt1776401522tbi8hl8j1 Message-ID: X-QQ-XMAILINFO: MyzM/wvJS/65avpCl0hg/WG7O4b7GrasBmQ8YqrMNBUFM/oL5AavFJh+khhAKf RmlORGNQLWzokLLOR4inv+s1As7mzQRyuc5buSdhfkGEfvTPt6FXDEqgjU0QMdwIh3Nwnz3jB43n 9DkvzymHK/I5Z+mSp2qaR2jJfDAlGBS++a8gJvlmpdBkDvOYUc0jKyj84Lrvea1syp1IGNfvgAPl HgWCr2w2Jg6eW8hzv373nmWUdXKYjipQMaD7mEKqtUiKIWMFoma1GmYhJsnqkkbij2MZzkOFxCra iGsKQb2G7ZU9xuUc1mnP41mwXatvFRVDtmtrumzv7/FLb3IpDsfakgPlW8bz6uxPQL4aWDZXAQnN RK1Y6OmyLiCNOi6bL8UGyl5jd3Bd22FHGVBrIhShz37azu2I0MSn8DEknV2FCtp1joc6qgRdUT9S LCBbQGhTluZJsFi2vtm2vIHOIpDsVP46r3YNq0rPE6q8cIpq54I3xSq8bZx2Wj8GXVbqtS4Kzkyx UAycu4MD4/4aa26/RDGBG6k7CuXHdEojFo8putD0iJWNA+JPNbW83JARECc7q/yrTSNBYmurGqaH CVaMAMbo/I8cqktT7yV+j1eFyFkc6S3BZnSqhKd+Ntq4owE1OrXaGCZl9CO6bxbKSSO4Gn/zvKT0 Dcvz7gjCb5Nhe7bx+SMr37OxduxVLLxNY5TWyUtwSBoacWUZghbz5MMnvrvsj8VP5rt7oX6MkKAP 497AI6u4MFSeWDTlkavmoip6C6EFnOG/9C1ha3u7NLZdPfL/Kfysqwz87m+alLkpblU7jupIOm9k 5lHmjV1PIemmoslaT10hUopJcaFzNM+9PQOVcCkXtjubXl5KJhCGHOSsQfM3FOAfCPxAFJOA9D2K 84UddIItNyRjU3MF4I0Yoxp1b4LuxMb6687f9HuA5RAzVltVcKe2LFDgDHp59kXEaPIzzvmwTZAx Ca3KiNFBKfbJ2YrrSKfOldBacAVvAQwZzkGtgwxlic2B9Tnu+VjFB/uLJJhXZxKLsmuMYqBsl5uq k3sIn3lmPn1n95Vg+d X-QQ-XMRINFO: NI4Ajvh11aEjEMj13RCX7UuhPEoou2bs1g== From: Edward Adam Davis To: syzbot+98547b0428b6a6a3467c@syzkaller.appspotmail.com Cc: linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com Subject: Re: [syzbot] [hfs?] memory leak in __hfs_bnode_create Date: Fri, 17 Apr 2026 12:52:03 +0800 X-OQ-MSGID: <20260417045202.407955-2-eadavis@qq.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <69e1934c.a70a0220.7229.0011.GAE@google.com> References: <69e1934c.a70a0220.7229.0011.GAE@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit #syz test diff --git a/fs/hfsplus/bnode.c b/fs/hfsplus/bnode.c index f8b5a8ae58ff..05287716afd8 100644 --- a/fs/hfsplus/bnode.c +++ b/fs/hfsplus/bnode.c @@ -604,7 +604,10 @@ struct hfs_bnode *hfs_bnode_find(struct hfs_btree *tree, u32 num) node_error: set_bit(HFS_BNODE_ERROR, &node->flags); - clear_bit(HFS_BNODE_NEW, &node->flags); + if (test_bit(HFS_BNODE_NEW, &node->flags)) { + hfs_bnode_free(node); + return ERR_PTR(-EIO); + } wake_up(&node->lock_wq); hfs_bnode_put(node); return ERR_PTR(-EIO);