mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Edward Adam Davis <eadavis@qq.com>
To: syzbot+bc70a12e438dadba4fb4@syzkaller.appspotmail.com
Cc: linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com
Subject: Re: [syzbot] [hfs?] general protection fault in __hfsplus_setxattr
Date: Wed, 15 Apr 2026 10:08:08 +0800	[thread overview]
Message-ID: <tencent_9B73676C3C013690967637784B58742D7609@qq.com> (raw)
In-Reply-To: <69decbcf.a00a0220.468cb.0069.GAE@google.com>

#syz test

diff --git a/fs/hfsplus/xattr.c b/fs/hfsplus/xattr.c
index 452a1f9becb2..3e6f45b3259d 100644
--- a/fs/hfsplus/xattr.c
+++ b/fs/hfsplus/xattr.c
@@ -317,12 +317,14 @@ static int hfsplus_create_attributes_file(struct super_block *sb)
 		next_node++;
 	}
 
-	hfsplus_mark_inode_dirty(HFSPLUS_ATTR_TREE_I(sb), HFSPLUS_I_ATTR_DIRTY);
 	hfsplus_mark_inode_dirty(attr_file, HFSPLUS_I_ATTR_DIRTY);
 
 	sbi->attr_tree = hfs_btree_open(sb, HFSPLUS_ATTR_CNID);
 	if (!sbi->attr_tree)
 		pr_err("failed to load attributes file\n");
+	else
+		hfsplus_mark_inode_dirty(HFSPLUS_ATTR_TREE_I(sb),
+					 HFSPLUS_I_ATTR_DIRTY);
 
 failed_header_node_init:
 	kfree(buf);


  reply	other threads:[~2026-04-15  2:08 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-14 23:20 syzbot
2026-04-15  2:08 ` Edward Adam Davis [this message]
2026-04-15  4:25   ` syzbot
2026-04-15  8:45 ` [PATCH] hfsplus: set attributes inode dirty at correct position Edward Adam Davis
2026-04-15 22:11   ` Viacheslav Dubeyko
2026-04-16  3:30     ` Edward Adam Davis
2026-04-16  3:37     ` [PATCH v2] hfsplus: Remove the duplicate attr inode dirty marking action Edward Adam Davis
2026-04-16 21:52       ` Viacheslav Dubeyko
2026-04-30 22:41 ` Forwarded: Re: [syzbot] [hfsplus?] general protection fault in __hfsplus_setxattr syzbot
     [not found] <177758890981.181190.2733813013414486501@gmail.com>
2026-04-30 23:57 ` [syzbot] [hfs?] " syzbot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tencent_9B73676C3C013690967637784B58742D7609@qq.com \
    --to=eadavis@qq.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=syzbot+bc70a12e438dadba4fb4@syzkaller.appspotmail.com \
    --cc=syzkaller-bugs@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®