From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out162-62-57-64.mail.qq.com (out162-62-57-64.mail.qq.com [162.62.57.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BBDC3280A5B for ; Fri, 9 Jan 2026 16:08:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=162.62.57.64 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767974934; cv=none; b=N3Asyvfu6U4Am/Mwu0qEtTbp9oR8CsNvLHIcyPhCONsRVnOvSsRiDTbD9paKAvUBeBIHworDyeRprURZdr0wTMfoQhcXtUNnEvYbq21gjRY3AvNKlDVp7MkkjQZNI40pYOqcyE56+98p1FUN9s1gRr658qAaowcjtZMtz9DOi8Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767974934; c=relaxed/simple; bh=VmG0IjkFMKKvljtWR+1gdEtADCopgYCP3qOzi2cciS0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=QysYVdpogd4lafR+5yhSVPgMa5WMlmbGpmPVlWtcudxcq68fwc59T1WdQ4Ki33yjF0hrjDAIURg2PjJExWE8zHGkOIZRKXhsfXTfo3S2F48qAwFRBlK4aYJ+uu5MiFHuRHzU0bu7+z3bhAS5z419eBd14kEUkpYTeJKFQKHK1yg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=qq.com; spf=pass smtp.mailfrom=qq.com; dkim=pass (1024-bit key) header.d=qq.com header.i=@qq.com header.b=vB2OrtDN; arc=none smtp.client-ip=162.62.57.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=qq.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=qq.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=qq.com header.i=@qq.com header.b="vB2OrtDN" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qq.com; s=s201512; t=1767974927; bh=H+XlO5WeBzUVCVq9gbZdWBNHbD6mzTIP7WNDywYc1qA=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=vB2OrtDN9vOGIXYV9W0DPzjUTA2BdwzKmifpB/KXw0Io8tG86JSW+TchjfKIMUXnB 8hL3xkLelLXGFF4KnHeT3GG2aZtpzrdWmusaVl9DSXFySX1uIjFIURdGzm2aO8bcuB O+h71mb9/LL0gzvMxPG51z3TutMfGvmWeowXknPU= Received: from [198.18.0.1] ([223.167.147.103]) by newxmesmtplogicsvrsza63-0.qq.com (NewEsmtp) with SMTP id 22CAFAC8; Sat, 10 Jan 2026 00:08:44 +0800 X-QQ-mid: xmsmtpt1767974924tnpqu9f0j Message-ID: X-QQ-XMAILINFO: MRMtjO3A6C9XF1FJVO/wIx+P3ZK8HbG4IQ6DFyiVJHzeRQOoiVlV9zj3jiN5gQ RoLHurX3ml79FPMMrA4aRR9QLF2xjiTQlbaUdzlbMX404l0fot0N34RRRHXk/xL7DQRVpx2HIZbJ lK/WKIwXNI0mUxZlrKX6tzscbAnsiFL+MWV6pdj7qHh5psbrEbmq0t7neQEtC2ghzmn9Ya6q0/WZ /lgi7llosrC6PYIFlDHVo56TAJmxGlNYaie7z/3CzwmQ3fmwolJo9ZP8U7XBPJTFUZyMbkyTH55+ b+JsMb4XpSRg3gYe3unNTVz8+SDFuB8KH/44qxYPZ4FV5mFjhSYnWjiPRVpxh+CyQXXUBoQBOxQv 8PyiOki6LVR/Ap2hjHS+cvNj5CeJCf3qwlIwXcFXbjq5Zn0kQR+rE/P8j3hjs17nlX1UMTH/Tgnp q847hb3z3Fjfs0pk/xOcfNsOj1X6N4HMyWcQh9ueWBRqTUEnj3sGGWdGchXSH1sp1rXvCxH0CiER LzTTVIFBECGIpzfNP9m8AvygmuSSJp6igqlBUi5OGc51fKI9UU8RVwPe5QLlMxv7a+lwa+Qsz7pw 5BJvKKht+eH9dMc+F2Z1rAJNed/TkptyqS2cC3F2bRWZT/KDZtHd3E7nxemayJ19/2wxCqD7HE1Z pK2cBywgeam0JELOXKKx5Q1PCrzqtaLtdSYt+KrUZBsdaDapVwDQCzDwiRAQmys8b3vC1x3R2BUk q7OcmrYn/SS5P4hdZ/TCmOHUj4iR7RpmAeu5ZPcZ7ja2DU3AlP7j9zCoWJsQt6/+KAmsjdcFynpj +zMu/00YJL0/JgEYyX4oUPOf1UrnDKBs24/bjbtpEi6xqIKVG+YNfw2DG+yjTyHvR9yUPoDegucO k4NRgX1Dt1JbnKNGnYWk0e8cev4G1D/DkvuhDWYhv8yk0SReu653662pa5/bTRHSre0IJn3c8+jq hiCn+DXHanJHiAnTIfqQ6HEfWJjhRTe5RvgV1LzwDg8gBafobVlqrd9NhYPtaehhtmZwchm6pZ3E RaObhQ0G4IHoR0Tn1+r0q3yfEFKZYDgrYHFme1dn68OdIryrv/Om81TnybKQrzrmOce6VCqA== X-QQ-XMRINFO: NS+P29fieYNw2GFZ5knjs7RF5PCtnBRWng== X-OQ-MSGID: Date: Sat, 10 Jan 2026 00:08:45 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mfd:tc3589:fix a potential resource leak To: Lee Jones Cc: linux-kernel@vger.kernel.org References: <20260109154139.GA1808297@google.com> From: Felix Gu In-Reply-To: <20260109154139.GA1808297@google.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi Jones, Thansk for review, I will fix it in V2. Best regards, Felix Gu 在 2026/1/9 23:41, Lee Jones 写道: > On Fri, 26 Dec 2025, Felix Gu wrote: > >> Use devm_request_threaded_irq to repalce request_threaded_irq to avoid >> a potential resource leak. >> >> Signed-off-by: Felix Gu >> --- >> drivers/mfd/tc3589x.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/mfd/tc3589x.c b/drivers/mfd/tc3589x.c >> index 2d4eb771e230..e3aaeb4701b8 100644 >> --- a/drivers/mfd/tc3589x.c >> +++ b/drivers/mfd/tc3589x.c >> @@ -410,7 +410,7 @@ static int tc3589x_probe(struct i2c_client *i2c) >> if (ret) >> return ret; >> >> - ret = request_threaded_irq(tc3589x->i2c->irq, NULL, tc3589x_irq, >> + ret = devm_request_threaded_irq(tc3589x->dev, tc3589x->i2c->irq, NULL, tc3589x_irq, >> IRQF_TRIGGER_FALLING | IRQF_ONESHOT, >> "tc3589x", tc3589x); > These two lines no longer line-up. Please fix. > >> if (ret) { >> >> --- >> base-commit: 3d845d25026c5b1050e927e3ee4c515977a9b490 >> change-id: 20251226-tc3589x-fix-50ce3358c7bf >> >> Best regards, >> -- >> Felix Gu >>