From: bo cao <treebacker@foxmail.com>
To: linux-kernel@vger.kernel.org
Cc: arnd@arndb.de, gregkh@linuxfoundation.org,
bo cao <treebacker@foxmail.com>
Subject: [PATCH] char: uv_mmtimer: prevent read-only mapping from becoming writable
Date: Thu, 29 Oct 2026 11:54:13 +0800 [thread overview]
Message-ID: <tencent_A595E3D79A2F77C2BA5A45A9874C46D55508@qq.com> (raw)
uv_mmtimer_mmap() rejects writable mappings but leaves VM_MAYWRITE
set. Userspace can map the clock's MMR page read-only and then
upgrade the mapping to writable with mprotect(), gaining write access
to the UVH_RTC register that the driver explicitly declares
read-only.
Clear VM_MAYWRITE, as fixed in vfio/platform (commit 420bed9131db),
drm/vc4 (CVE-2026-68445), drm/panthor (CVE-2024-53071) and
ptp/vmclock (commit a5edadbae57e).
Note this is defensive hardening on two counts: /dev/uv_mmtimer is
created with the default 0600 mode (exploitation requires root), and
the driver only exists on SGI UV systems.
Fixes: fbd8ae106850 ("drivers/char/uv_mmtimer.c: add memory mapped RTC driver for UV")
Signed-off-by: bo cao <treebacker@foxmail.com>
---
drivers/char/uv_mmtimer.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/char/uv_mmtimer.c b/drivers/char/uv_mmtimer.c
index 956ebe2080a5..98b9c85c6529 100644
--- a/drivers/char/uv_mmtimer.c
+++ b/drivers/char/uv_mmtimer.c
@@ -151,9 +151,12 @@ static int uv_mmtimer_mmap(struct file *file, struct vm_area_struct *vma)
if (vma->vm_end - vma->vm_start != PAGE_SIZE)
return -EINVAL;
+ /* Prevent the read-only mapping from being upgraded with mprotect() */
if (vma->vm_flags & VM_WRITE)
return -EPERM;
+ vm_flags_clear(vma, VM_MAYWRITE);
+
if (PAGE_SIZE > (1 << 16))
return -ENOSYS;
--
2.39.5 (Apple Git-154)
next reply other threads:[~2026-10-29 3:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-29 3:54 bo cao [this message]
2026-10-29 6:56 ` Greg KH
2026-10-29 7:09 ` bo cao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tencent_A595E3D79A2F77C2BA5A45A9874C46D55508@qq.com \
--to=treebacker@foxmail.com \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®