From: Edward Adam Davis <eadavis@qq.com>
To: syzbot+784d0a1246a539975f05@syzkaller.appspotmail.com
Cc: linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com
Subject: Re: [syzbot] [rcu?] WARNING in rcu_note_context_switch (2)
Date: Tue, 23 Jul 2024 21:44:10 +0800 [thread overview]
Message-ID: <tencent_A688921FDD9E5D95993ACFF58D87259B0D07@qq.com> (raw)
In-Reply-To: <000000000000d0e3b5061dc16993@google.com>
miss rcu read unlock
#syz test: upstream 51835949dda3
diff --git a/fs/nsfs.c b/fs/nsfs.c
index a4a925dce331..e228d06f0949 100644
--- a/fs/nsfs.c
+++ b/fs/nsfs.c
@@ -188,8 +188,10 @@ static long ns_ioctl(struct file *filp, unsigned int ioctl,
tsk = find_task_by_vpid(arg);
else
tsk = find_task_by_pid_ns(arg, pid_ns);
- if (!tsk)
+ if (!tsk) {
+ rcu_read_unlock();
break;
+ }
switch (ioctl) {
case NS_GET_PID_FROM_PIDNS:
next prev parent reply other threads:[~2024-07-23 13:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-21 12:53 syzbot
2024-07-21 16:37 ` Paul E. McKenney
2024-07-22 3:38 ` Z qiang
2024-07-22 3:55 ` Paul E. McKenney
2024-07-22 6:42 ` Z qiang
2024-07-22 17:55 ` Boqun Feng
2024-07-23 13:44 ` Edward Adam Davis [this message]
2024-07-23 14:13 ` syzbot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tencent_A688921FDD9E5D95993ACFF58D87259B0D07@qq.com \
--to=eadavis@qq.com \
--cc=linux-kernel@vger.kernel.org \
--cc=syzbot+784d0a1246a539975f05@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®