mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Yangyu Chen <cyy@cyyself.name>
To: Conor Dooley <conor@kernel.org>
Cc: Damien Le Moal <dlemoal@kernel.org>,
	linux-riscv@lists.infradead.org, Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>, Guo Ren <guoren@kernel.org>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	Conor Dooley <conor.dooley@microchip.com>
Subject: Resend: Re: [PATCH v3 5/7] riscv: Kconfig.socs: Allow SOC_CANAAN with MMU for K230
Date: Wed, 6 Mar 2024 01:50:25 +0800	[thread overview]
Message-ID: <tencent_AA20462764AFF185EF405043DBC99119F705@qq.com> (raw)
In-Reply-To: <20240305-fascism-enrich-06483ddeb149@spud>

The last email was not received in the list due to I didn’t change the mode
to plaintext. Sorry for that. This is a resend email.

> On Mar 6, 2024, at 01:20, Conor Dooley <conor@kernel.org> wrote:
> 
> On Tue, Mar 05, 2024 at 03:47:15PM +0800, Yangyu Chen wrote:
>> On 2024/3/5 07:46, Damien Le Moal wrote:
>>> On 3/5/24 06:05, Yangyu Chen wrote:
>>>> Since K230 was released, SOC_CANAAN is no longer only referred to the K210.
>>>> Remove it depends on !MMU will allow building dts for K230 and remove the
>>>> K210 string from the help message.
>>>> 
>>>> Signed-off-by: Yangyu Chen <cyy@cyyself.name>
>>>> Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
>>>> ---
>>>>  arch/riscv/Kconfig.socs | 5 ++---
>>>>  1 file changed, 2 insertions(+), 3 deletions(-)
>>>> 
>>>> diff --git a/arch/riscv/Kconfig.socs b/arch/riscv/Kconfig.socs
>>>> index 623de5f8a208..b4e9b7f75510 100644
>>>> --- a/arch/riscv/Kconfig.socs
>>>> +++ b/arch/riscv/Kconfig.socs
>>>> @@ -75,13 +75,12 @@ config ARCH_CANAAN
>>>>   def_bool SOC_CANAAN
>>>>  config SOC_CANAAN
>>>> - bool "Canaan Kendryte K210 SoC"
>>>> - depends on !MMU
>>> 
>>> This seems wrong to me. The k210 support does require no-mmu. So why remove
>>> this ?
>> 
>> It just allows SOC_CANAAN to be selected when MMU=y. With this patch,
>> nommu_k210_defconfig still works.
> 
> I think the concern here is that this would allow people to build a
> kernel for the k120 with the MMU enabled, not that the existing nommu
> build will be affected.
> 

Aha. I don't think is there anyone will try a build with MMU on
K210. It only has 6MB of memory available to the CPU. For rv64 if
the S-Mode software starts at 2MB, it will only have 4MB for S-Mode
Linux. It's hard to trim the kernel and fit in 4MB and even preserve
some memory for userspace.

I also tried to make nommu_k210_defconfig on gcc 13.2.0, it produced a
1.6M kernel in arch/riscv/boot/Image. But if I use nconfig to set
CONFIG_MMU=y and rebuild, the kernel file will increase to 11M.

> Maybe you could squash in something like the following?
> 
> diff --git a/arch/riscv/Kconfig.socs b/arch/riscv/Kconfig.socs
> index b4e9b7f75510..75d55059163f 100644
> --- a/arch/riscv/Kconfig.socs
> +++ b/arch/riscv/Kconfig.socs
> @@ -72,15 +72,19 @@ config SOC_VIRT
>   This enables support for QEMU Virt Machine.
> 
> config ARCH_CANAAN
> - def_bool SOC_CANAAN
> + bool "Canaan Kendryte SoCs"
> + help
> +   This enables support for Canaan Kendryte SoC platform hardware.
> 
> config SOC_CANAAN
> - bool "Canaan Kendryte SoC"
> + bool "Canaan Kendryte K210 SoC"
> + depends on !MMU
> + depends on ARCH_CANAAN
> select CLINT_TIMER if RISCV_M_MODE
> select ARCH_HAS_RESET_CONTROLLER
> select PINCTRL
> select COMMON_CLK
> help
> -   This enables support for Canaan Kendryte SoC platform hardware.
> +   This enables support for Canaan Kendryte K210 SoC platform hardware.
> 
> endmenu # "SoC selection"
> 
> (Which reminds me, I really need to go and finish sorting out the ARCH_
> stuff)

Seems like an idea if we want this consideration. But I don't think we need
this as the opinions shown above.

If it should be, I think SOC_CANAAN should be renamed to SOC_K210 or
SOC_CANAAN_K210.


  reply	other threads:[~2024-03-05 17:50 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-04 21:03 [PATCH v3 0/7] riscv: add initial support for Canaan Kendryte K230 Yangyu Chen
2024-03-04 21:05 ` [PATCH v3 1/7] dt-bindings: riscv: Add T-HEAD C908 compatible Yangyu Chen
2024-03-04 21:05 ` [PATCH v3 2/7] dt-bindings: add Canaan K230 boards compatible strings Yangyu Chen
2024-03-04 23:44   ` Damien Le Moal
2024-03-04 21:05 ` [PATCH v3 3/7] dt-bindings: timer: Add Canaan K230 CLINT Yangyu Chen
2024-03-05 14:47   ` Rob Herring
2024-03-04 21:05 ` [PATCH v3 4/7] dt-bindings: interrupt-controller: Add Canaan K230 PLIC Yangyu Chen
2024-03-05 14:48   ` Rob Herring
2024-03-04 21:05 ` [PATCH v3 5/7] riscv: Kconfig.socs: Allow SOC_CANAAN with MMU for K230 Yangyu Chen
2024-03-04 23:46   ` Damien Le Moal
2024-03-05  7:47     ` Yangyu Chen
2024-03-05 17:20       ` Conor Dooley
2024-03-05 17:50         ` Yangyu Chen [this message]
2024-03-05 18:32           ` Resend: " Yangyu Chen
2024-03-05 23:58         ` Damien Le Moal
2024-03-07 21:03           ` Yangyu Chen
2024-03-13 16:56             ` Yangyu Chen
2024-03-15  8:19               ` Damien Le Moal
2024-03-04 21:06 ` [PATCH v3 6/7] riscv: dts: add initial canmv-k230 and k230-evb dts Yangyu Chen
2024-03-05 15:54   ` Palmer Dabbelt
2024-03-05 16:22     ` Yangyu Chen
     [not found]     ` <7A86D933-B85F-4B29-8D6D-AB414A42AC06@cyyself.name>
2024-03-05 16:37       ` Yangyu Chen
2024-03-05 17:01         ` Conor Dooley
2024-03-05 17:17           ` Yangyu Chen
2024-03-05 17:24             ` Conor Dooley
2024-03-04 21:06 ` [PATCH v3 7/7] riscv: config: enable SOC_CANAAN in defconfig Yangyu Chen
2024-03-04 23:50   ` Damien Le Moal
2024-03-05 16:55     ` Yangyu Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tencent_AA20462764AFF185EF405043DBC99119F705@qq.com \
    --to=cyy@cyyself.name \
    --cc=aou@eecs.berkeley.edu \
    --cc=conor.dooley@microchip.com \
    --cc=conor@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dlemoal@kernel.org \
    --cc=guoren@kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=palmer@dabbelt.com \
    --cc=paul.walmsley@sifive.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®