From: Edward Adam Davis <eadavis@qq.com>
To: syzbot+f1bb7e4ea47ea12b535c@syzkaller.appspotmail.com
Cc: abbotti@mev.co.uk, hsweeten@visionengravers.com,
linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com
Subject: [PATCH] comedi: aio_iiro_16: Prevent invlaid irq number
Date: Tue, 8 Jul 2025 20:37:21 +0800 [thread overview]
Message-ID: <tencent_B0B82F456DC094ECE982EF1ECCEC7AEA6D0A@qq.com> (raw)
In-Reply-To: <686bf6a0.a00a0220.b087d.01f2.GAE@google.com>
The irq number 0x2166 passed by the reproducer is too large and is not
within the supported range [2-7, 10-12, 14, or 15], which triggers the oob.
Fixes: ad7a370c8be4 ("staging: comedi: aio_iiro_16: add command support for change of state detection")
Reported-by: syzbot+f1bb7e4ea47ea12b535c@syzkaller.appspotmail.com
Closes: https://syzkaller.appspot.com/bug?extid=f1bb7e4ea47ea12b535c
Signed-off-by: Edward Adam Davis <eadavis@qq.com>
---
drivers/comedi/drivers/aio_iiro_16.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/comedi/drivers/aio_iiro_16.c b/drivers/comedi/drivers/aio_iiro_16.c
index b00fab0b89d4..e43730f00c8b 100644
--- a/drivers/comedi/drivers/aio_iiro_16.c
+++ b/drivers/comedi/drivers/aio_iiro_16.c
@@ -177,7 +177,8 @@ static int aio_iiro_16_attach(struct comedi_device *dev,
* Digital input change of state interrupts are optionally supported
* using IRQ 2-7, 10-12, 14, or 15.
*/
- if ((1 << it->options[1]) & 0xdcfc) {
+ if (it->options[1] > 1 && it->options[1] < 16 &&
+ (1 << it->options[1]) & 0xdcfc) {
ret = request_irq(it->options[1], aio_iiro_16_cos, 0,
dev->board_name, dev);
if (ret == 0)
--
2.43.0
next prev parent reply other threads:[~2025-07-08 12:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-07 16:32 [syzbot] [kernel?] UBSAN: shift-out-of-bounds in aio_iiro_16_attach syzbot
2025-07-08 12:17 ` Edward Adam Davis
2025-07-08 12:37 ` syzbot
2025-07-08 12:37 ` Edward Adam Davis [this message]
2025-07-08 13:18 ` [PATCH] comedi: aio_iiro_16: Prevent invlaid irq number Ian Abbott
2025-09-28 19:08 ` Abhinav Saxena
2025-09-28 0:36 ` Forwarded: Re: [syzbot] [kernel?] UBSAN: shift-out-of-bounds in aio_iiro_16_attach syzbot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tencent_B0B82F456DC094ECE982EF1ECCEC7AEA6D0A@qq.com \
--to=eadavis@qq.com \
--cc=abbotti@mev.co.uk \
--cc=hsweeten@visionengravers.com \
--cc=linux-kernel@vger.kernel.org \
--cc=syzbot+f1bb7e4ea47ea12b535c@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®