From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out203-205-221-173.mail.qq.com (out203-205-221-173.mail.qq.com [203.205.221.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ED07930EF7C for ; Fri, 17 Apr 2026 06:24:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=203.205.221.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776407043; cv=none; b=Tu+d5QtUCNyM5KZuO14KRezkVWUxvxfzO+n10U/uygmywHYI3hjMgToPaukhVeOvWUIE0EFg0E3RMSuYgf9pX2Ol0TM6ig3MzMNK56St1zVSqtLw01bfdwfv5BhOR3lPx9aCK/etxsz9HpKs4acX66Jua/voSyG3qpq6w/ZHlUY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776407043; c=relaxed/simple; bh=IEsab/PsKt4VEeld3utqNp7PpXFIL/sPAFwCXqYf0KQ=; h=Message-ID:From:To:Cc:Subject:Date:In-Reply-To:References: MIME-Version; b=ZscJR2ZTe6BP1HfFgJ/LZWxPCKtOhS/TQoQ2NJ4oQvAsBhSZ8WROkqtrClWZ0uqIBiLvjs4c1w1kEpjU93V7kxYSeMIkwwwx3Vb5KMCjOuuf687Q74RKOMeZgClzPoltAm4h7AmB5C+U5zVnQcP9g5303VEC2qUc45unRjk84y4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=qq.com; spf=pass smtp.mailfrom=qq.com; dkim=pass (1024-bit key) header.d=qq.com header.i=@qq.com header.b=fCf84mNj; arc=none smtp.client-ip=203.205.221.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=qq.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=qq.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=qq.com header.i=@qq.com header.b="fCf84mNj" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qq.com; s=s201512; t=1776407038; bh=u14h0/FLZvsp+4brxuh3CziArxNH0hZqJGRZ4xT9ktA=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=fCf84mNjKtnzvI2B32UHNBldF8BJEKsxGUxY57HFDboVq4CZftu63PyPKSDjYIpQo VGfCLpIddhAyBlNqyVMSqqAebNmVjw3yXRXlVPpv/0JGC82lHC1gBWuERrCHpBCKsO afL42RspWpwiJ3AN/Tm/fSer8Xi4oe0f+JdaVDxE= Received: from lxu-ped-host.. ([111.198.231.89]) by newxmesmtplogicsvrszb43-0.qq.com (NewEsmtp) with SMTP id 5B08CA91; Fri, 17 Apr 2026 14:22:48 +0800 X-QQ-mid: xmsmtpt1776406968tkf4jjxdo Message-ID: X-QQ-XMAILINFO: M1JY6XCfJolWJo99rJ9dsvnxi6yb09J4d5/ytPRr+kbE0jZBlD0T6QRU6XOssk BmGVqhU8Q+yUahWQXWQyBqkVVby/y5C9XyT/N6dL5PDEmBa3WBnb9MditqDQEPS8sF4bZ1KZ3dU0 0GhCwbwyauVcLo4rgIolM7fXTWTSPZHM7qOoWCvQKA6F0YBa/fQKka2bUr8v++VjJ3oW84W2p/zr d85FO+BI08oKaspVtzf0cDnQGgwvF7iPdnPhE+A6jVGS59pYLUSGJViPwfy4ng5HttH6IczHVvpo +fxU5rCg2WT6vw52KqtCv0pckyQuNppIXOIUW5k665Xg4oGxrm1InQnIl7dRseH/MODM2jZcxFWB Qbye+gdjaRRHHLnjWRMbhHSNqzGm8WPkiDqLYBu/hWVSXQGRGlRWtatziFft3hlBN1iwl6O5G8vl XXy3DPHYEqfgXKmeFvP/tk5Uv91AI32wJ/Vl9MG4QdiNlYInIaX3R3L34Mli+uPG3b+VVbK5PgVb H0XQm+TPHXL2mYtAxnfStHKLFcGkl+1ufWCMq4IHFeh0TvE2cP0051qLT2SqI05TXTd9womHhTuZ r1BiGfn/fRWDwhRzFu0cOttnkkG0fMR9vEFp8CAKMdyZldc98LVVgTlTs+ROLG/q02+tr/PERJ7M 2De0xA6VioNxAp3R82yQUIetc8A9BQY0RF1C1XS+HUeUjZa+i04P3X93hnM9QJRqX/Bu5RjQtj2y 9RvIXXlJOMIFJgjv8FqawMtcNDiBNyUeBufrAY2gsXZG+DZgHQwNMOB/eIMQlzb1Ip/QF8Dt6wTC A7LvsJG0xGa1ZxTII22HUkBJ2yGyzLqYL4FX3Bl/+Kdpo6On5tu937tYOJTzgOR66FSiDRCRCXw/ IKllDhQYPcPKwsIKTbQh+1aRY4vNKGpnynuwh8pDyslssYWCKPIpC++pm4J1Ee50Ju4biXB/eYDI eYJF38NDihsx6CVjHeQEM5yyqgF5WXotAkvEV1dH30+/hqHtjX/j9vl4krpdtDE97UAolQFisnuP eq8XIoH/Rws1bKmUvNEZiW3zY7AMwt4zNX0FErtA== X-QQ-XMRINFO: Mp0Kj//9VHAxzExpfF+O8yhSrljjwrznVg== From: Edward Adam Davis To: syzbot+98547b0428b6a6a3467c@syzkaller.appspotmail.com Cc: linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com Subject: Re: [syzbot] [hfs?] memory leak in __hfs_bnode_create Date: Fri, 17 Apr 2026 14:22:49 +0800 X-OQ-MSGID: <20260417062248.414369-2-eadavis@qq.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <69e1934c.a70a0220.7229.0011.GAE@google.com> References: <69e1934c.a70a0220.7229.0011.GAE@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit #syz test diff --git a/fs/hfsplus/bnode.c b/fs/hfsplus/bnode.c index f8b5a8ae58ff..65902104882a 100644 --- a/fs/hfsplus/bnode.c +++ b/fs/hfsplus/bnode.c @@ -598,14 +598,18 @@ struct hfs_bnode *hfs_bnode_find(struct hfs_btree *tree, u32 num) if (key_size >= entry_size || key_size & 1) goto node_error; } - clear_bit(HFS_BNODE_NEW, &node->flags); - wake_up(&node->lock_wq); + if (num != HFSPLUS_TREE_HEAD) { + clear_bit(HFS_BNODE_NEW, &node->flags); + wake_up(&node->lock_wq); + } return node; node_error: set_bit(HFS_BNODE_ERROR, &node->flags); - clear_bit(HFS_BNODE_NEW, &node->flags); - wake_up(&node->lock_wq); + if (num != HFSPLUS_TREE_HEAD) { + clear_bit(HFS_BNODE_NEW, &node->flags); + wake_up(&node->lock_wq); + } hfs_bnode_put(node); return ERR_PTR(-EIO); } @@ -694,6 +698,10 @@ void hfs_bnode_put(struct hfs_bnode *node) hfs_bnode_free(node); return; } + if (test_bit(HFS_BNODE_NEW, &node->flags)) { + hfs_bnode_unhash(node); + hfs_bnode_free(node); + } spin_unlock(&tree->hash_lock); } }