mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "谢致邦 (XIE Zhibang)" <Yeking@Red54.com>
To: linux-input@vger.kernel.org, hansg@kernel.org,
	dmitry.torokhov@gmail.com, bentiss@kernel.org
Cc: Yeking@Red54.com, dianders@chromium.org, jikos@kernel.org,
	linux-kernel@vger.kernel.org, sashiko-bot@kernel.org,
	sashiko-reviews@lists.linux.dev, superm1@kernel.org
Subject: Re: [PATCH v3] HID: i2c-hid: Refactor _DSM helper and add i2c-hid-acpi-prp0001 driver
Date: Tue,  9 Jun 2026 10:10:35 +0000	[thread overview]
Message-ID: <tencent_C2BEF7C0584BFE713DC7B41FFD7007B6D30A@qq.com> (raw)
In-Reply-To: <4243c594-6535-4111-86cb-69784b0a34b7@kernel.org>

Hi Hans,

Thanks for the review.

The current header-based approach lets i2c-hid-acpi-prp0001.c work
independently by just including a header for the _DSM helper. Switching
to EXPORT_SYMBOL_GPL would force prp0001 to depend on i2c-hid-acpi —
a Kconfig "depends on I2C_HID_ACPI", plus module-level dependency at
load time — all for sharing a single function. I find that hard to
accept.

I understand that adding a new header for one prototype is unusual,
though it contains only a single static inline function and introduces
no runtime dependency between the two drivers.

Looking back at the full discussion: Benjamin made it clear from the
start that he doesn't want i2c-hid-of.c handling ACPI _DSM fallback.
His line is that ACPI devices and OF devices should each go through
their own drivers without cross-contamination. If you still prefer
exporting the function from i2c-hid-acpi.c, then prp0001 would have to
drag i2c-hid-acpi along with it — an independent leaf driver turned
into something that can't stand alone.

If you still prefer the export approach, then I'd rather take a simpler
approach: add an of_match directly to
i2c-hid-acpi.c, and return -ENODEV silently at the top of probe if
hid-descr-addr is present. Same logic as the prp0001 driver, but one
fewer file, no module dependency, no extra Kconfig entry, and no OF
driver touching ACPI devices — which should also satisfy Benjamin's
concern.

Regards,
Zhibang


  reply	other threads:[~2026-06-09 10:11 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20260605014101.1889E1F00893@smtp.kernel.org>
2026-06-05 12:20 ` [PATCH v2] " 谢致邦 (XIE Zhibang)
2026-06-06 16:06   ` [PATCH v3] " 谢致邦 (XIE Zhibang)
2026-06-08 11:48     ` Hans de Goede
2026-06-08 11:51       ` Hans de Goede
2026-06-09 10:10         ` 谢致邦 (XIE Zhibang) [this message]
2026-06-09 10:21           ` 谢致邦 (XIE Zhibang)
2026-06-09 10:54             ` [PATCH v4] " 谢致邦 (XIE Zhibang)
2026-06-09 13:07           ` [PATCH v3] " Hans de Goede
2026-06-23  2:05             ` 谢致邦 (XIE Zhibang)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tencent_C2BEF7C0584BFE713DC7B41FFD7007B6D30A@qq.com \
    --to=yeking@red54.com \
    --cc=bentiss@kernel.org \
    --cc=dianders@chromium.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=hansg@kernel.org \
    --cc=jikos@kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sashiko-bot@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=superm1@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®