From: Yangyu Chen <cyy@cyyself.name>
To: ebiggers@kernel.org
Cc: andy.chiu@sifive.com, aou@eecs.berkeley.edu, ardb@kernel.org,
christoph.muellner@vrull.eu, heiko@sntech.de,
hongrong.hsu@sifive.com, jerry.shih@sifive.com,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-riscv@lists.infradead.org, palmer@dabbelt.com,
paul.walmsley@sifive.com, phoebe.chen@sifive.com
Subject: Re: [PATCH v3 05/10] crypto: riscv - add vector crypto accelerated ChaCha20
Date: Fri, 12 Apr 2024 15:59:08 +0800 [thread overview]
Message-ID: <tencent_C7B10C572AA62E84ABF1818F52904DFBCA05@qq.com> (raw)
In-Reply-To: <20240122002024.27477-6-ebiggers@kernel.org>
On 2024/1/22 08:19, Eric Biggers wrote:> From: Jerry Shih <jerry.shih@sifive.com>
>
> Add an implementation of ChaCha20 using the Zvkb extension. The
> assembly code is derived from OpenSSL code (openssl/openssl#21923) that
> was dual-licensed so that it could be reused in the kernel.
> Nevertheless, the assembly has been significantly reworked for
> integration with the kernel, for example by using a regular .S file
> instead of the so-called perlasm, using the assembler instead of bare
> '.inst', and reducing code duplication.
>
> Signed-off-by: Jerry Shih <jerry.shih@sifive.com>
> Co-developed-by: Eric Biggers <ebiggers@google.com>
> Signed-off-by: Eric Biggers <ebiggers@google.com>
> ---
Hi, Jerry Shih and Eric Biggers,
Since this implementation is derived from OpenSSL, I have an issue on
OpenSSL about this chacha20 implementation using Zvkb [1] and see a fixes
PR by Jerry Shih [2].
I wonder will kernel need to port those fixes to handle the non-multiple
block length of the chacha20 cipher? If yes, we should port it immediately
to catch up with the v6.9 release if we can.
[1] https://github.com/openssl/openssl/issues/24070
[2] https://github.com/openssl/openssl/pull/24097
Thanks,
Yangyu Chen
next prev parent reply other threads:[~2024-04-12 8:38 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-22 0:19 [PATCH v3 00/10] RISC-V crypto with reworked asm files Eric Biggers
2024-01-22 0:19 ` [PATCH v3 01/10] RISC-V: add helper function to read the vector VLEN Eric Biggers
2024-01-22 0:19 ` [PATCH v3 02/10] RISC-V: add TOOLCHAIN_HAS_VECTOR_CRYPTO Eric Biggers
2024-01-22 0:19 ` [PATCH v3 03/10] RISC-V: hook new crypto subdir into build-system Eric Biggers
2024-01-22 0:19 ` [PATCH v3 04/10] crypto: riscv - add vector crypto accelerated AES-{ECB,CBC,CTR,XTS} Eric Biggers
2024-01-22 0:19 ` [PATCH v3 05/10] crypto: riscv - add vector crypto accelerated ChaCha20 Eric Biggers
2024-04-12 7:59 ` Yangyu Chen [this message]
2024-04-12 8:07 ` Jerry Shih
2024-01-22 0:19 ` [PATCH v3 06/10] crypto: riscv - add vector crypto accelerated GHASH Eric Biggers
2024-01-22 0:19 ` [PATCH v3 07/10] crypto: riscv - add vector crypto accelerated SHA-{256,224} Eric Biggers
2024-01-22 0:19 ` [PATCH v3 08/10] crypto: riscv - add vector crypto accelerated SHA-{512,384} Eric Biggers
2024-01-22 0:19 ` [PATCH v3 09/10] crypto: riscv - add vector crypto accelerated SM3 Eric Biggers
2024-01-22 0:19 ` [PATCH v3 10/10] crypto: riscv - add vector crypto accelerated SM4 Eric Biggers
2024-01-23 1:58 ` [PATCH v3 00/10] RISC-V crypto with reworked asm files Palmer Dabbelt
2024-01-23 15:06 ` Christoph Müllner
2024-01-23 17:50 ` patchwork-bot+linux-riscv
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tencent_C7B10C572AA62E84ABF1818F52904DFBCA05@qq.com \
--to=cyy@cyyself.name \
--cc=andy.chiu@sifive.com \
--cc=aou@eecs.berkeley.edu \
--cc=ardb@kernel.org \
--cc=christoph.muellner@vrull.eu \
--cc=ebiggers@kernel.org \
--cc=heiko@sntech.de \
--cc=hongrong.hsu@sifive.com \
--cc=jerry.shih@sifive.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=phoebe.chen@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®