mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Edward Adam Davis <eadavis@qq.com>
To: syzbot+9d34f80f841e948c3fdb@syzkaller.appspotmail.com
Cc: linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com
Subject: Re: [syzbot] [usb?] KMSAN: kernel-usb-infoleak in usbtmc_write
Date: Wed,  4 Sep 2024 20:47:46 +0800	[thread overview]
Message-ID: <tencent_CE76CFE28DD5A5A20DF7121F5DDBDDB71907@qq.com> (raw)
In-Reply-To: <000000000000a338d6062149eb22@google.com>

prevent kernel-infoleak.
We need to clear the structure before filling fields.

#syz test

diff --git a/drivers/usb/class/usbtmc.c b/drivers/usb/class/usbtmc.c
index 6bd9fe565385..e9ddaa9b580d 100644
--- a/drivers/usb/class/usbtmc.c
+++ b/drivers/usb/class/usbtmc.c
@@ -759,6 +759,7 @@ static struct urb *usbtmc_create_urb(void)
 		usb_free_urb(urb);
 		return NULL;
 	}
+	memset(dmabuf, 0, bufsize);
 
 	urb->transfer_buffer = dmabuf;
 	urb->transfer_buffer_length = bufsize;


  reply	other threads:[~2024-09-04 12:54 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-25  9:14 syzbot
2024-09-04 12:00 ` syzbot
2024-09-04 12:47   ` Edward Adam Davis [this message]
2024-09-04 13:33     ` syzbot
2024-09-04 13:55   ` [PATCH] USB: usbtmc: prevent kernel-infoleak Edward Adam Davis
2024-09-04 14:09     ` Greg KH
2024-09-04 14:13       ` Greg KH
2024-09-05 13:56         ` Edward Adam Davis
2024-09-05 14:04           ` Greg KH
2024-09-05 14:16             ` Edward Adam Davis
2024-09-06 14:11               ` [PATCH V2] USB: usbtmc: prevent kernel-usb-infoleak Edward Adam Davis
2024-09-06 14:28                 ` Alan Stern
2024-09-07  2:08                   ` Edward Adam Davis
2024-09-07 14:45                     ` Alan Stern
2024-09-08  0:59                       ` Edward Adam Davis
2024-09-08  1:32                         ` Alan Stern
2024-09-08  2:01                           ` Edward Adam Davis
2024-09-08  2:20                           ` [PATCH V3] " Edward Adam Davis
2024-09-08  5:20                             ` Greg KH
2024-09-08  7:35                               ` Edward Adam Davis
2024-09-08  7:54                                 ` Greg KH
2024-09-08  8:16                                   ` Edward Adam Davis
2024-09-08  8:33                                     ` Greg KH
2024-09-08  9:17                                       ` [PATCH v4] " Edward Adam Davis
2024-09-05 11:27   ` [syzbot] [usb?] KMSAN: kernel-usb-infoleak in usbtmc_write Edward Adam Davis
2024-09-05 15:42     ` syzbot
2024-09-05 14:21   ` Edward Adam Davis
2024-09-05 16:11     ` syzbot
2024-09-06 11:55   ` Edward Adam Davis
2024-09-06 12:29     ` syzbot
2024-09-06 12:37   ` Edward Adam Davis
2024-09-06 13:07     ` syzbot
2024-09-06 13:06   ` Edward Adam Davis
2024-09-06 13:51     ` syzbot
2024-09-06 13:52   ` Edward Adam Davis
2024-09-06 16:59     ` syzbot
2024-09-05  7:11 ` [syzbot] " syzbot
2024-09-05  8:29 ` syzbot
     [not found] <20240905071112.1621278-1-lizhi.xu@windriver.com>
2024-09-05  7:57 ` syzbot
     [not found] <20240905082935.2536851-1-lizhi.xu@windriver.com>
2024-09-05  8:59 ` syzbot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tencent_CE76CFE28DD5A5A20DF7121F5DDBDDB71907@qq.com \
    --to=eadavis@qq.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=syzbot+9d34f80f841e948c3fdb@syzkaller.appspotmail.com \
    --cc=syzkaller-bugs@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®