From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out203-205-221-205.mail.qq.com (out203-205-221-205.mail.qq.com [203.205.221.205]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E88B4341ACA for ; Fri, 17 Apr 2026 03:11:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=203.205.221.205 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776395490; cv=none; b=Kv3QPV35H8+dsMt0LjJQ1UMqhZOeqJ5OYzCdJKs6OiBcYnq0b1Af8byVaam7dpaP1Aau7UxAeg2SZNV0gkTO9byV+rkoteNZ3xCvjelxd1iP0i+nz/MJrx+IG97abmwA4Rc6LiLLCyIUz4TX0DiA+T1ORndKigRq7UuvMupUjxs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776395490; c=relaxed/simple; bh=qCI9/AQ+KcMzneC+6G6cMg9q+tGL7Gv3d43wfvGUIAQ=; h=Message-ID:From:To:Cc:Subject:Date:In-Reply-To:References: MIME-Version; b=LWOy3jYto4GAh4ZzEkr2QdTs8QlxaB2ApHwWf/5K/bMConQSFL8OjtXnkSrR1+taYzCGMdb2YXYsY7MBFb982yYAZ5iAZOqsYSAADzlM5l+WJBOJiE9Jpq6MbMuSGeUlfdEMv+yPHRXqoI/SylZtENrujUD5raad2xdFG3i88oI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=qq.com; spf=pass smtp.mailfrom=qq.com; dkim=pass (1024-bit key) header.d=qq.com header.i=@qq.com header.b=CDPYQ7ya; arc=none smtp.client-ip=203.205.221.205 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=qq.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=qq.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=qq.com header.i=@qq.com header.b="CDPYQ7ya" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qq.com; s=s201512; t=1776395478; bh=r1pj299dviGIQmzlYt3ys3HiR3giHsETreT5L900AcU=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=CDPYQ7yaygRwP+7FcJ+fbsNzEO1cvnjh5yjLOD5XckPlXCI0dsXNUZ45G8222r+Gd wYLF4Qt/9qG5Y2/tiBfHNLYEP6MOz0UmSO4sYNhD4aKURCsS2jkY4TP9E5O3H4MOih at9vmuyf+9LSFCsbELCxLa7GK5ePirZrt4PDx+40= Received: from lxu-ped-host.. ([111.198.231.89]) by newxmesmtplogicsvrszb43-0.qq.com (NewEsmtp) with SMTP id 2CFAE631; Fri, 17 Apr 2026 11:11:15 +0800 X-QQ-mid: xmsmtpt1776395475tgyqbgboz Message-ID: X-QQ-XMAILINFO: N84LmEYa7WqoF4HuDdQCsxhV1lNtlCdgxleg2358ZRB7ofmRuYsYxJU/5d8VNm mQCDF6F0MJdPdWBSq3VLdgCaUy4b8OGK7kG5QhmZSHxo8PU3dHQijGZPfuVbBW4aPEPctmvG2bJi /F5BgD/IfbqfQfpxYbS9x11Hyep1p+i4QNGE3kl1Xwg+oCaGVh1gZLEr5Mf1wd4jHVzT7rQ+3clr L/Jr5j0ilJffl1gcyWb3KXhcTFoK3lSYwUQ+uBoSIobMMweDjg4uLa0zRntF4lX6wWaZFWd/ki40 3DUw9jWdfnBu/VfzP6UgpD50Z7Zvuf12yYH7i3ZmUWvn6K4kYsGRttOgwGzNfEtThHWvVGXgRHRd DOLayGhc62vlpABp2ubiN61c14RxgLrAU8inkq/7SjjqCBl9rJpuvs2hHOsnA95B8XzqI7Q26Yy/ 7rwPfKfjrr3wEbjC277CZ0A9oj+Q0vJrEGW1R/JEJ74LctMhaP39BgAXoNtJ4iJBtpQIFkjXftcS x8MEis2ki54GPHspXXO2+BQRHaMPpMhYHsw3PIW0df0+Uc8f7jYIgyYT+uxUZ24VHfBzA6pPCtuD TeLFf3het0bpCyFMcasNAEzLTS08Ygj3ANNceoLbeBdrvdbETzOZ4JIQHl4M0WXBMcMzLjYO1CjZ OdA36+QvuSfIBEfoyXOeK+anX5zhHn7TPtJX5KamQzq/YV46FWHGnmroEErmVrnW/5t6LSwf3+7H v82mAeDZ/04FloXhkW8JcbJNTOyQ7rcf403hv6bNDE420sTwmLUOIRCuKylTqZx3MstdgneadyM8 fk/41oekl/2qNKcRV98Ol30TEqHyVnOX8qBjQbA8bJnurEQW5I1z+1dw+emtK35aOwkKqzkzkTCv 6ZbifbamSzjA+8A3aUN9WiQBf05tWZVxPUY5sMwbdpVA5ZW0wSBjgFOiaKgQ2c8vq2QxGtkGaSXb W3o6dyP+3EWIVaQml1FxRoUpQcZHxjR1QJpI90XS52ZRlzZF5no1aZHWGVvgsbP5c8zg54XQQ= X-QQ-XMRINFO: NI4Ajvh11aEjEMj13RCX7UuhPEoou2bs1g== From: Edward Adam Davis To: syzbot+98547b0428b6a6a3467c@syzkaller.appspotmail.com Cc: linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com Subject: Re: [syzbot] [hfs?] memory leak in __hfs_bnode_create Date: Fri, 17 Apr 2026 11:11:15 +0800 X-OQ-MSGID: <20260417031114.403751-2-eadavis@qq.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <69e1934c.a70a0220.7229.0011.GAE@google.com> References: <69e1934c.a70a0220.7229.0011.GAE@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit #syz test diff --git a/fs/hfsplus/btree.c b/fs/hfsplus/btree.c index 394542a47e60..926e4b40a065 100644 --- a/fs/hfsplus/btree.c +++ b/fs/hfsplus/btree.c @@ -270,7 +270,7 @@ struct hfs_btree *hfs_btree_open(struct super_block *sb, u32 id) struct hfs_btree *tree; struct hfs_btree_header_rec *head; struct address_space *mapping; - struct hfs_bnode *node; + struct hfs_bnode *node = NULL; struct inode *inode; struct page *page; unsigned int size; @@ -401,6 +401,8 @@ struct hfs_btree *hfs_btree_open(struct super_block *sb, u32 id) put_page(page); free_inode: tree->inode->i_mapping->a_ops = &hfsplus_aops; + if (!IS_ERR_OR_NULL(node)) + hfs_bnode_put(node); iput(tree->inode); free_tree: kfree(tree);